From owner-dev-commits-ports-all@freebsd.org Fri Jun 18 17:58:42 2021 Return-Path: Delivered-To: dev-commits-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3D99864ABB9; Fri, 18 Jun 2021 17:58:42 +0000 (UTC) (envelope-from rhurlin@gwdg.de) Received: from xmailer.gwdg.de (xmailer.gwdg.de [134.76.10.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4G669Y46Ydz54P1; Fri, 18 Jun 2021 17:58:41 +0000 (UTC) (envelope-from rhurlin@gwdg.de) Received: from excmbx-03.um.gwdg.de ([134.76.9.218] helo=email.gwdg.de) by mailer.gwdg.de with esmtp (GWDG Mailer) (envelope-from ) id 1luIlL-0007tc-Fo; Fri, 18 Jun 2021 19:58:39 +0200 Received: from krabat.raven.hur (10.250.9.200) by EXCMBX-03.um.gwdg.de (134.76.9.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P521) id 15.1.2242.10; Fri, 18 Jun 2021 19:58:39 +0200 Subject: Re: git: aeb2d6000af2 - main - x11/kitty: Update to 0.21.1 To: Jan Beich CC: , , References: <202106181538.15IFcT8N077481__15247.3101437621$1624030723$gmane$org@gitrepo.freebsd.org> <1r8z-map7-wny@FreeBSD.org> Reply-To: Rainer Hurling From: Rainer Hurling Message-ID: <6da3c915-4441-95ff-2fc2-2544eb3ccf52@gwdg.de> Date: Fri, 18 Jun 2021 19:58:29 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <1r8z-map7-wny@FreeBSD.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.250.9.200] X-ClientProxiedBy: EXCMBX-02.um.gwdg.de (134.76.9.217) To EXCMBX-03.um.gwdg.de (134.76.9.218) X-Virus-Scanned: (clean) by clamav X-Rspamd-Queue-Id: 4G669Y46Ydz54P1 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of rhurlin@gwdg.de designates 134.76.10.29 as permitted sender) smtp.mailfrom=rhurlin@gwdg.de X-Spamd-Result: default: False [-3.50 / 15.00]; HAS_REPLYTO(0.00)[rhurlin@FreeBSD.org]; HAS_XOIP(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:134.76.10.0/23]; REPLYTO_DN_EQ_FROM_DN(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; RCVD_IN_DNSWL_MED(-0.20)[134.76.10.29:from]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:680, ipnet:134.76.0.0/16, country:DE]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FREEFALL_USER(0.00)[rhurlin]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; REPLYTO_DOM_NEQ_FROM_DOM(0.00)[]; DMARC_NA(0.00)[gwdg.de]; MIME_TRACE(0.00)[0:+]; RWL_MAILSPIKE_VERYGOOD(0.00)[134.76.10.29:from]; MAILMAN_DEST(0.00)[dev-commits-ports-main,dev-commits-ports-all] X-BeenThere: dev-commits-ports-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jun 2021 17:58:42 -0000 Am 18.06.21 um 17:52 schrieb Jan Beich: > Rainer Hurling writes: > >> The branch main has been updated by rhurlin: >> >> URL: https://cgit.FreeBSD.org/ports/commit/?id=aeb2d6000af2536c0e7f8be228cc267cefe76a09 >> >> commit aeb2d6000af2536c0e7f8be228cc267cefe76a09 >> Author: Rainer Hurling >> AuthorDate: 2021-06-18 15:33:34 +0000 >> Commit: Rainer Hurling >> CommitDate: 2021-06-18 15:33:34 +0000 >> >> x11/kitty: Update to 0.21.1 >> >> Fix a regression in the previous release that could cause >> a crash when changing layouts and mousing. >> >> Changelog: https://sw.kovidgoyal.net/kitty/changelog.html#id1 >> >> PR: 256678 >> Reported by: Alexis Praga (maintainer) > > Why are you using "Reported by" when the patch was *submitted* by maintainer? > Same for the previous update (9176f36cbb6a). TIMESTAMP in distinfo matches. > > https://docs.freebsd.org/en/articles/committers-guide/#_include_appropriate_metadata_in_a_footer > Hi Jan, Thanks for pointing that out and apologies. I did not intend to disguise authorship in this way. In memory I still had that 'Submitted by:' should not be used anymore. I will use --author again in the future, as I have done several times before. BTW: 'Reported by:' also seems to be used by several others in commits that are based on a PR. This might have something to do with the fact that commits without authorship are otherwise not listed in the contributions graph of Github ... Regards, Rainer