From owner-freebsd-gecko@freebsd.org Mon Nov 9 19:56:23 2015 Return-Path: Delivered-To: freebsd-gecko@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E81F9A2A1DC for ; Mon, 9 Nov 2015 19:56:23 +0000 (UTC) (envelope-from jbeich@vfemail.net) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id C783E18FA for ; Mon, 9 Nov 2015 19:56:23 +0000 (UTC) (envelope-from jbeich@vfemail.net) Received: by mailman.ysv.freebsd.org (Postfix) id C4D6EA2A1D6; Mon, 9 Nov 2015 19:56:23 +0000 (UTC) Delivered-To: gecko@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C4631A2A1D5 for ; Mon, 9 Nov 2015 19:56:23 +0000 (UTC) (envelope-from jbeich@vfemail.net) Received: from vfemail.net (fivefive.neocoil.com [12.31.100.155]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1D40D18F8 for ; Mon, 9 Nov 2015 19:56:22 +0000 (UTC) (envelope-from jbeich@vfemail.net) Received: (qmail 33006 invoked by uid 89); 8 Nov 2015 17:14:30 -0000 Received: from localhost (HELO freequeue.vfemail.net) (127.0.0.1) by localhost with (DHE-RSA-AES256-SHA encrypted) SMTP; 8 Nov 2015 17:14:29 -0000 Received: (qmail 32979 invoked by uid 89); 8 Nov 2015 17:14:12 -0000 Received: by simscan 1.3.1 ppid: 32971, pid: 32976, t: 0.0036s scanners:none Received: from unknown (HELO smtp102-2.vfemail.net) (172.16.100.62) by FreeQueue with SMTP; 8 Nov 2015 17:14:12 -0000 Received: (qmail 568 invoked by uid 89); 8 Nov 2015 17:14:20 -0000 Received: by simscan 1.4.0 ppid: 549, pid: 557, t: 0.5993s scanners:none Received: from unknown (HELO nil) (amJlaWNoQHZmZW1haWwubmV0@172.16.100.27) by 172.16.100.62 with ESMTPA; 8 Nov 2015 17:14:20 -0000 From: Jan Beich To: "Marat N.Afanasyev" Cc: Steve Wills , Louis Epstein , gecko@freebsd.org Subject: Re: Seamonkey port? References: <20151104230905.Q98665-100000@main.put.com> <563B6A1E.9000806@li.ru> <563BA5F1.2080503@FreeBSD.org> <563C9BA8.7010006@li.ru> <563F155E.7030705@li.ru> Date: Sun, 08 Nov 2015 18:14:05 +0100 In-Reply-To: <563F155E.7030705@li.ru> (Marat N. Afanasyev's message of "Sun, 08 Nov 2015 12:26:54 +0300") Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: freebsd-gecko@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Gecko Rendering Engine issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Nov 2015 19:56:24 -0000 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable "Marat N.Afanasyev" writes: > /usr/bin/ld: libxul.so: hidden symbol `downmix_int' isn't defined Adding -lopus won't be enough. Firefox hides any symbol not explicitly listed as system with pragma visibility, see config/system-headers. However, downmix_int isn't really a public symbol. So, you either have to disable system opus via USE_MOZILLA=3D-opus like r386162 or apply the following hack Index: audio/opus/Makefile =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =2D-- audio/opus/Makefile (revision 401065) +++ audio/opus/Makefile (working copy) @@ -2,7 +2,7 @@ =20 PORTNAME=3D opus PORTVERSION=3D 1.1 =2DPORTREVISION=3D 2 +PORTREVISION=3D 3 CATEGORIES=3D audio MASTER_SITES=3D http://downloads.xiph.org/releases/opus/ \ MOZILLA/opus @@ -24,9 +24,7 @@ CONFIGURE_ARGS=3D --enable-custom-modes \ INSTALL_TARGET=3D install-strip TEST_TARGET=3D check =20 =2D.include =2D =2D.if ${ARCH} =3D=3D "arm" +.if defined(MACHINE_CPU) && ${MACHINE_CPU:Msoftfp} CONFIGURE_ARGS+=3D--enable-fixed-point .endif =20 Index: audio/opus/files/patch-export-downmix =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =2D-- audio/opus/files/patch-export-downmix (nonexistent) +++ audio/opus/files/patch-export-downmix (working copy) @@ -0,0 +1,28 @@ +--- include/opus.h.orig 2013-11-29 20:49:17 UTC ++++ include/opus.h +@@ -971,6 +971,14 @@ OPUS_EXPORT OPUS_WARN_UNUSED_RESULT opus +=20 + /**@}*/ +=20 ++#ifdef __SOFTFP__ /* XXX FIXED_POINT isn't exported */ ++OPUS_EXPORT void downmix_float(const void *_x, opus_int32 *sub, int subfr= ame, int offset, int c1, int c2, int C); ++OPUS_EXPORT void downmix_int(const void *_x, opus_int32 *sub, int subfram= e, int offset, int c1, int c2, int C); ++#else ++OPUS_EXPORT void downmix_float(const void *_x, float *sub, int subframe, = int offset, int c1, int c2, int C); ++OPUS_EXPORT void downmix_int(const void *_x, float *sub, int subframe, in= t offset, int c1, int c2, int C); ++#endif ++ + #ifdef __cplusplus + } + #endif +--- src/opus_private.h.orig 2013-11-29 20:17:16 UTC ++++ src/opus_private.h +@@ -83,8 +83,6 @@ int get_mono_channel(const ChannelLayout + #define OPUS_SET_FORCE_MODE(x) OPUS_SET_FORCE_MODE_REQUEST, __opus_check_= int(x) +=20 + typedef void (*downmix_func)(const void *, opus_val32 *, int, int, int, i= nt, int); +-void downmix_float(const void *_x, opus_val32 *sub, int subframe, int off= set, int c1, int c2, int C); +-void downmix_int(const void *_x, opus_val32 *sub, int subframe, int offse= t, int c1, int c2, int C); +=20 + int optimize_framesize(const opus_val16 *x, int len, int C, opus_int32 Fs, + int bitrate, opus_val16 tonality, float *mem, int bufferi= ng, --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQF8BAEBCgBmBQJWP4LdXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQjQ0MzY3NEM3RDIzNTc4NkUxNDkyQ0VF NEM3Nzg4MzQ3OURCRERCAAoJEOTHeINHnb3bWIsIAIWiSo1ItDH9j76Heu4pnDau DanD+Pf1xRKKHG9pGSNq0DcJ+qtbD3SrNifuSqaXBCmrO95YQaFJpJW0VpcU+WRY Py1B1eoyW8oJd+hxor/D/sf4ZAb80/+4Dg6cUe0xcvx8JfYIn7dGtpLHjvygUAaw cMYKhW7DBCDW3weUrx2ZSUzncXeBuJJi/G7JZ47/nz6i4zhovfJQ5JiKuYgxHDN9 jAxJMGbcHLNus/tOojX6YKteN2au+uDw9TgleTuE3Cl7eC4UuJlYeAn2c4czos95 2mlPkNxhQbXbJGzLGoNFHb94i/aAgfneyz7gJkrQyznrXuzGzNFS40fQW3RGy3Y= =YXIK -----END PGP SIGNATURE----- --=-=-=--