From owner-freebsd-net@freebsd.org Fri Jan 8 17:03:11 2016 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 43C18A68F69 for ; Fri, 8 Jan 2016 17:03:11 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-io0-x242.google.com (mail-io0-x242.google.com [IPv6:2607:f8b0:4001:c06::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1706D1290 for ; Fri, 8 Jan 2016 17:03:11 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mail-io0-x242.google.com with SMTP id f81so5938012iof.0 for ; Fri, 08 Jan 2016 09:03:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=qde5PyuqYEHS1R/AbapfgGhn5mJRtZCN3ye5n6vCfxY=; b=Bw70YKv/HYEZO+z6Gb+AgSh2vRGjGTLgNCBDMB+0EzLeIkKNaQ5tNJqMnyRwYRkuUO 4moWcQFOTCzcSA05A5ZctUeXbm60yoL1NFCUAfw9bQopyWe9wH2XsAJPmJaMsi236gKG ubu3AM0R+RJvhLAQd8Oa8+eENsZd04rVousRRfrWOqktdEvyIikhkLtV/tJFU7H0fLft ZYl/d+/8b6c7atmJ9wnEdC8qoQfj4DYT9ExGsiUNBrp8jT/T9AWNuxUqRBPJtZxYzxW5 bF3dvAxiPPg6sbDm8ARTFPupmHrrcge/46MZCLqzbnlnG624siu+OITYdoVyxhb/X26b 19PA== MIME-Version: 1.0 X-Received: by 10.107.10.217 with SMTP id 86mr90688485iok.75.1452272590482; Fri, 08 Jan 2016 09:03:10 -0800 (PST) Received: by 10.36.121.202 with HTTP; Fri, 8 Jan 2016 09:03:10 -0800 (PST) In-Reply-To: References: Date: Fri, 8 Jan 2016 09:03:10 -0800 Message-ID: Subject: Re: [Differential] [Request, 6 lines] D4825: tcp/lro: Add network driver configurable LRO entry depth From: Adrian Chadd To: Ravi Pokala Cc: "freebsd-net@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jan 2016 17:03:11 -0000 On 8 January 2016 at 07:59, Ravi Pokala wrote: > -----Original Message----- > > >>Date: Fri, 8 Jan 2016 02:29:22 +0000 >>From: "sepherosa_gmail.com (Sepherosa Ziehau)" >> >>To: freebsd-net@freebsd.org >>Subject: [Differential] [Request, 6 lines] D4825: tcp/lro: Add network >> driver configurable LRO entry depth >>Message-ID: >> >>Content-Type: text/plain; charset="utf-8" >> >>sepherosa_gmail.com created this revision. >>sepherosa_gmail.com added reviewers: network, adrian, delphij, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com, glebius. >>sepherosa_gmail.com added a subscriber: freebsd-net-list. >>Herald added a reviewer: transport. >> >>REVISION SUMMARY >> When there is only tiny amount of TCP connections and the host is slow, e.g. in VM, holding too much TCP segments in an LRO entry will cause RX performance degradation. We now allow network drivers to configure how deep one LRO entry should be. > > Forgive me if I'm missing something obvious, but this patch doesn't actually change anything - rather than hard-coding 65535, you're using lc->lro_hiwat... which is hard-coded to 65535. > > Right? > Right; I'm assuming their driver will twiddle this appropriately over time. -a > -Ravi (rpokala@) > > _______________________________________________ > freebsd-net@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"