From owner-svn-src-head@FreeBSD.ORG Mon Jun 22 20:14:00 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 53AD21065670; Mon, 22 Jun 2009 20:14:00 +0000 (UTC) (envelope-from rnoland@FreeBSD.org) Received: from gizmo.2hip.net (gizmo.2hip.net [64.74.207.195]) by mx1.freebsd.org (Postfix) with ESMTP id EF5938FC08; Mon, 22 Jun 2009 20:13:59 +0000 (UTC) (envelope-from rnoland@FreeBSD.org) Received: from [192.168.1.4] (adsl-19-252-27.bna.bellsouth.net [68.19.252.27]) (authenticated bits=0) by gizmo.2hip.net (8.14.3/8.14.3) with ESMTP id n5MKDvIR071659 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 22 Jun 2009 16:13:57 -0400 (EDT) (envelope-from rnoland@FreeBSD.org) From: Robert Noland To: John Baldwin In-Reply-To: <200906222008.n5MK87qh050928@svn.freebsd.org> References: <200906222008.n5MK87qh050928@svn.freebsd.org> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-b6nYufckr34JTA/TVGss" Organization: FreeBSD Date: Mon, 22 Jun 2009 15:13:51 -0500 Message-Id: <1245701631.1761.22.camel@balrog.2hip.net> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 FreeBSD GNOME Team Port X-Spam-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RDNS_DYNAMIC, SPF_SOFTFAIL autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on gizmo.2hip.net Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r194644 - head/sys/dev/pci X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jun 2009 20:14:00 -0000 --=-b6nYufckr34JTA/TVGss Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Mon, 2009-06-22 at 20:08 +0000, John Baldwin wrote: > Author: jhb > Date: Mon Jun 22 20:08:06 2009 > New Revision: 194644 > URL: http://svn.freebsd.org/changeset/base/194644 >=20 > Log: > Enable MSI in the MSI capability registers any time that the first mess= age > in an MSI group is enabled, not just if the address/data pair are not > initialized. This should fix the issues with broken interrupts with drm on Intel graphics chips using msi. That is the slow windows after VT Switch issue. It however is still currently broken on HEAD due to another issue, which will hopefully be resolved soon. robert. =20 > Reported by: rnoland > MFC after: 1 week >=20 > Modified: > head/sys/dev/pci/pci.c >=20 > Modified: head/sys/dev/pci/pci.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/dev/pci/pci.c Mon Jun 22 19:35:39 2009 (r194643) > +++ head/sys/dev/pci/pci.c Mon Jun 22 20:08:06 2009 (r194644) > @@ -2883,8 +2883,10 @@ pci_setup_intr(device_t dev, device_t ch > goto bad; > dinfo->cfg.msi.msi_addr =3D addr; > dinfo->cfg.msi.msi_data =3D data; > - pci_enable_msi(child, addr, data); > } > + if (dinfo->cfg.msi.msi_handlers =3D=3D 0) > + pci_enable_msi(child, dinfo->cfg.msi.msi_addr, > + dinfo->cfg.msi.msi_data); > dinfo->cfg.msi.msi_handlers++; > } else { > KASSERT(dinfo->cfg.msix.msix_alloc > 0, --=20 Robert Noland FreeBSD --=-b6nYufckr34JTA/TVGss Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.11 (FreeBSD) iEYEABECAAYFAko/5f8ACgkQM4TrQ4qfROMU8ACeOZviG8vpOiACUm0FQ3+79aUI hY8AmgNs3BqY1XVF+77KJ4J75PkRtTz1 =tFqk -----END PGP SIGNATURE----- --=-b6nYufckr34JTA/TVGss--