From owner-svn-src-all@FreeBSD.ORG  Sun Oct 28 21:26:51 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id A29FD743;
 Sun, 28 Oct 2012 21:26:51 +0000 (UTC)
 (envelope-from rpaulo@felyko.com)
Received: from felyko.com (unknown [IPv6:2607:f2f8:a528::3:1337:ca7])
 by mx1.freebsd.org (Postfix) with ESMTP id 7F7D78FC18;
 Sun, 28 Oct 2012 21:26:51 +0000 (UTC)
Received: from [IPv6:2601:9:4d00:85:8077:b284:3e1f:accb] (unknown
 [IPv6:2601:9:4d00:85:8077:b284:3e1f:accb])
 (using TLSv1 with cipher AES128-SHA (128/128 bits))
 (No client certificate requested)
 by felyko.com (Postfix) with ESMTPSA id 13BDF3982B;
 Sun, 28 Oct 2012 14:26:51 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=felyko.com; s=mail;
 t=1351459611; bh=Fr3CXmPq8xZHx1xaf4vlJ4+A0hPVRfBR+HffVlcr+ZA=;
 h=Subject:From:In-Reply-To:Date:Cc:References:To;
 b=QzMlfYBo4O51kSgvdvku0YONIvsQDqCXxp3ONv5pPS8WLgsdu/iIliT2BBePRtu8U
 EmgJ1hgbu3H0cq8WkmVDclOZp+Llke69BTyhNl8yfg9l1T51tAzr8eiZlNS4chFLp4
 M+DAcVdqb0sen89aBUiSQrQoQ8Ltbbo1u7pJ4/FY=
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 6.2 \(1499\))
Subject: Re: svn commit: r242263 - head/sys/netinet
From: Rui Paulo <rpaulo@felyko.com>
In-Reply-To: <201210281920.q9SJKNS0081242@svn.freebsd.org>
Date: Sun, 28 Oct 2012 14:26:46 -0700
Content-Transfer-Encoding: quoted-printable
Message-Id: <0220FA6E-FFCB-4489-BF57-3493C2531DD7@felyko.com>
References: <201210281920.q9SJKNS0081242@svn.freebsd.org>
To: Andre Oppermann <andre@FreeBSD.org>
X-Mailer: Apple Mail (2.1499)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 28 Oct 2012 21:26:51 -0000

On 28 Oct 2012, at 12:20, Andre Oppermann <andre@FreeBSD.org> wrote:

> Author: andre
> Date: Sun Oct 28 19:20:23 2012
> New Revision: 242263
> URL: http://svn.freebsd.org/changeset/base/242263
>=20
> Log:
>  Add SACK_PERMIT to the list of TCP options that are switched off =
after
>  retransmitting a SYN three times.
>=20
>  MFC after:	2 weeks
>=20
> Modified:
>  head/sys/netinet/tcp_timer.c
>=20
> Modified: head/sys/netinet/tcp_timer.c
> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
> --- head/sys/netinet/tcp_timer.c	Sun Oct 28 19:16:22 2012	=
(r242262)
> +++ head/sys/netinet/tcp_timer.c	Sun Oct 28 19:20:23 2012	=
(r242263)
> @@ -585,7 +585,7 @@ tcp_timer_rexmt(void * xtp)
> 	 * unknown-to-them TCP options.
> 	 */
> 	if ((tp->t_state =3D=3D TCPS_SYN_SENT) && (tp->t_rxtshift =3D=3D =
3))
> -		tp->t_flags &=3D ~(TF_REQ_SCALE|TF_REQ_TSTMP);
> +		tp->t_flags &=3D =
~(TF_REQ_SCALE|TF_REQ_TSTMP|TF_SACK_PERMIT);
> 	/*
> 	 * If we backed off this far, our srtt estimate is probably =
bogus.
> 	 * Clobber it so we'll take the next rtt measurement as our =
srtt;

Do you have any data regarding this commit or you're just trying to make =
sure the SACK option follows the same behaviour of the WSCALE/TSTMP =
options?

Regards,
--
Rui Paulo