Date: Thu, 2 Oct 2003 08:00:55 -0700 (PDT) From: Jacques Vidrine <nectar@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/fs/procfs procfs_dbregs.c procfs_fpregs.c procfs_regs.c src/sys/fs/pseudofs pseudofs_vnops.c src/sys/kern kern_subr.c src/sys/sys uio.h Message-ID: <200310021500.h92F0tl1036507@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
nectar 2003/10/02 08:00:55 PDT
FreeBSD src repository
Modified files:
sys/fs/procfs procfs_dbregs.c procfs_fpregs.c
procfs_regs.c
sys/fs/pseudofs pseudofs_vnops.c
sys/kern kern_subr.c
sys/sys uio.h
Log:
Introduce a uiomove_frombuf helper routine that handles computing and
validating the offset within a given memory buffer before handing the
real work off to uiomove(9).
Use uiomove_frombuf in procfs to correct several issues with
integer arithmetic that could result in underflows/overflows. As a
side-effect, the code is significantly simplified.
Add additional sanity checks when computing a memory allocation size
in pfs_read.
Submitted by: rwatson (original uiomove_frombuf -- bugs are mine :-)
Reported by: Joost Pol <joost@pine.nl> (integer underflows/overflows)
Revision Changes Path
1.23 +3 -15 src/sys/fs/procfs/procfs_dbregs.c
1.29 +3 -15 src/sys/fs/procfs/procfs_fpregs.c
1.28 +3 -15 src/sys/fs/procfs/procfs_regs.c
1.42 +17 -15 src/sys/fs/pseudofs/pseudofs_vnops.c
1.77 +23 -0 src/sys/kern/kern_subr.c
1.28 +1 -0 src/sys/sys/uio.h
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200310021500.h92F0tl1036507>