From owner-svn-ports-all@FreeBSD.ORG Sat Oct 19 16:41:37 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id DDEEBACE for ; Sat, 19 Oct 2013 16:41:37 +0000 (UTC) (envelope-from sunpoet@sunpoet.net) Received: from mail-la0-f43.google.com (mail-la0-f43.google.com [209.85.215.43]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 698C523CB for ; Sat, 19 Oct 2013 16:41:37 +0000 (UTC) Received: by mail-la0-f43.google.com with SMTP id el20so1497138lab.16 for ; Sat, 19 Oct 2013 09:41:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=seYQVbOyRVOSjCET0q+n//R/QtAOqwCRZk+pIIfvURA=; b=Dtx9vYJHp/bNAPUhynrQxRG3zZklSM9GoQaRugWiq0CS+Bj+LOlpzS7nokwbW2RFf7 BrIotMU2TY4TREWwCTpAyl8up5T6/BpHty2CNzglrkJiZas69uJ4gq2Y64jA8nFRM89G oN70NvdyLrV78ANKnWbIuvY2oCki0tL8+iBIoi/iNBSHY5y/OUXT4USsGtZDEsQ3Qd3g 79kCqTx9GKN27mCqNWf8AKHCtQUz/eEIRLtoWW2vHFJvHzfE9xlDnZu/ggbVVJDHuEuy fSIaXrIr+I4vJR9sPIFbhlnhzNurkRQ2snRq5HQ2NcqwFymIALpDq9SPijuXbxXpmFW3 +JnQ== X-Gm-Message-State: ALoCoQlUj8inMovSqg0Y3/cS5QDlCbhuX1MSkBA0TdFCDr3DriAfQ1XysnMUjpLkkbpXitCPifxf X-Received: by 10.152.6.169 with SMTP id c9mr6015470laa.28.1382200889264; Sat, 19 Oct 2013 09:41:29 -0700 (PDT) MIME-Version: 1.0 Received: by 10.112.91.9 with HTTP; Sat, 19 Oct 2013 09:41:09 -0700 (PDT) In-Reply-To: <201310190017.r9J0HAbg020596@svn.freebsd.org> References: <201310190017.r9J0HAbg020596@svn.freebsd.org> From: Sunpoet Hsieh Date: Sun, 20 Oct 2013 00:41:09 +0800 Message-ID: Subject: Re: svn commit: r330810 - head/Mk/Scripts To: Baptiste Daroussin Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Oct 2013 16:41:37 -0000 On Sat, Oct 19, 2013 at 8:17 AM, Baptiste Daroussin wrote: > Author: bapt > Date: Sat Oct 19 00:17:10 2013 > New Revision: 330810 > URL: http://svnweb.freebsd.org/changeset/ports/330810 > > Log: > Recommand to use STRIP_CMD to strip binaries given that it will respect > the WITH_DEBUG option > > Modified: > head/Mk/Scripts/qa.sh > > Modified: head/Mk/Scripts/qa.sh > > ============================================================================== > --- head/Mk/Scripts/qa.sh Sat Oct 19 00:14:22 2013 (r330809) > +++ head/Mk/Scripts/qa.sh Sat Oct 19 00:17:10 2013 (r330810) > @@ -66,7 +66,7 @@ stripped() { > for f in `find ${STAGEDIR} -type f`; do > output=`/usr/bin/file ${f}` > case "${output}" in > - *:*\ ELF\ *,\ not\ stripped*) warn "${f} is not stripped";; > + *:*\ ELF\ *,\ not\ stripped*) warn "${f} is not stripped > consider using \${STRIP_CMD}";; > esac > done > } > _______________________________________________ > svn-ports-all@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/svn-ports-all > To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org" > MAKE_ENV= INSTALL_STRIP_FLAG=${STRIP} is also a possible way which respects WITH_DEBUG. Could this be added to qa.sh? Regards, sunpoet