From owner-freebsd-arch@FreeBSD.ORG Sat Oct 20 18:18:33 2012 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 54CF4EE6 for ; Sat, 20 Oct 2012 18:18:33 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id DF5608FC08 for ; Sat, 20 Oct 2012 18:18:32 +0000 (UTC) Received: from skuns.kiev.zoral.com.ua (localhost [127.0.0.1]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id q9KIIcoR000583; Sat, 20 Oct 2012 21:18:38 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5) with ESMTP id q9KIIQhI040068; Sat, 20 Oct 2012 21:18:26 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5/Submit) id q9KIIQg4040067; Sat, 20 Oct 2012 21:18:26 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 20 Oct 2012 21:18:26 +0300 From: Konstantin Belousov To: Peter Wemm Subject: Re: using SSE2 in kernel C code (improving AES-NI module) Message-ID: <20121020181826.GE35915@deviant.kiev.zoral.com.ua> References: <20121019233833.GS1967@funkthat.com> <20121020054847.GB35915@deviant.kiev.zoral.com.ua> <20121020171124.GU1967@funkthat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="q2efgaiYRy6GdUpU" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.0 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: freebsd-arch@freebsd.org X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Oct 2012 18:18:33 -0000 --q2efgaiYRy6GdUpU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Oct 20, 2012 at 11:10:37AM -0700, Peter Wemm wrote: > On Sat, Oct 20, 2012 at 10:11 AM, John-Mark Gurney wro= te: > > Konstantin Belousov wrote this message on Sat, Oct 20, 2012 at 08:48 +0= 300: > >> On Fri, Oct 19, 2012 at 04:38:33PM -0700, John-Mark Gurney wrote: > >> > So, the AES-NI module already uses SSE2 instructions, but it does so > >> > only in assembly. I have improved the performance of the AES-NI > >> > modules implementation, but this involves me using additional SSE2 > >> > instructions. > >> > > >> > In order to keep my sanity, I did part of the new code in C using > >> > gcc native types and xmmintrin.h, but we do not support this header = in > >> > the kernel.. This means we cannot simply add the new code to the > >> > kernel... > >> > > >> > Any good ideas on how to integrate this code into the kernel build? > > > > [...] > > > >> > >> The current structure of the aes-ni driver is partly enforced by the > >> issue you noted. We cannot use sse intristics in the kernel, and > >> huge inline assembler fragments are hard to write. > >> > >> I prefer to have the separate .S files with the optimized code, > >> hand-written. If needed, I offer you a help with transition. I would > >> need a full patch to rewrite the code. > > > > Are you sure you want to do this? It'll involve writing around 500 > > lines of assembly besides the constants... And it isn't simple like > > the aesni_enc where we have a single loop for the rounds... I've > > posted a tar.gz to overlay onto sys/crypto/aesni at: > > https://www.funkthat.com/~jmg/aesni.repfile.tar.gz >=20 > Rather than go straight to assembler, why not use the __builtins? >=20 > static inline __m128i > xts_crank_lfsr(__m128i inp) > { > const __m128i alphamask =3D _mm_set_epi32(1, 1, 1, AES_XTS_ALPHA); > __m128i xtweak, ret; >=20 > /* set up xor mask */ > xtweak =3D _mm_shuffle_epi32(inp, 0x93); > xtweak =3D _mm_srai_epi32(xtweak, 31); > xtweak &=3D alphamask; >=20 > /* next term */ > ret =3D _mm_slli_epi32(inp, 1); > ret ^=3D xtweak; >=20 > return ret; > } >=20 > --> >=20 > static inline __m128i > xts_crank_lfsr(__m128i inp) > { > const __m128i alphamask =3D (magic casts){ 1, 1, 1, AES_XTS_ALPHA= }; > __m128i xtweak, ret; >=20 > /* set up xor mask */ > xtweak =3D __builtin_ia32_pshufd (inp, 0x93); > xtweak =3D __builtin_ia32_psradi128(xtweak, 31); > xtweak &=3D alphamask; >=20 > /* next term */ > ret =3D __builtin_ia32_pslldi128(inp, 1); > ret ^=3D xtweak; >=20 > return ret; > } > I know I skipped the details like data types, but most of the meat of > those functions collapses to a simple wrapper around a __builtin. Are builtins available for -mno-sse compilation ? I think we can try to reimplement the builtins needed with inline assembly. >=20 > Or, another option.. do something like genassym or the many other > kernel build tools. aicasm builds and runs a userland tool to > generate something to build into the kernel. With sufficient > cross-contamination safeguards I wonder if something similar might be > able to be done here. >=20 > --=20 > Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com; KI6F= JV > "All of this is for nothing if we don't go to the stars" - JMS/B5 > "If Java had true garbage collection, most programs would delete > themselves upon execution." -- Robert Sewell --q2efgaiYRy6GdUpU Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAlCC6vIACgkQC3+MBN1Mb4hAjQCgz1gcbmOjWckG3SoEdiu+iI5G tS0An0idGjpvu5as8W3w9dz9EENqcrFd =RfrP -----END PGP SIGNATURE----- --q2efgaiYRy6GdUpU--