Date: Mon, 21 Jul 2008 22:38:00 +0800 (CST) From: Yi-Jheng Lin <yzlin@cs.nctu.edu.tw> To: FreeBSD-gnats-submit@FreeBSD.org Cc: mark@foster.cc Subject: ports/125833: [PATCH] net/iscsi-target: make rc script to support iscsi_target_flags Message-ID: <200807211438.m6LEc05d004983@stucgi.cs.nctu.edu.tw> Resent-Message-ID: <200807211450.m6LEo3KK054702@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 125833 >Category: ports >Synopsis: [PATCH] net/iscsi-target: make rc script to support iscsi_target_flags >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Mon Jul 21 14:50:03 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Yi-Jheng Lin >Release: FreeBSD 7.0-RELEASE-p1 amd64 >Organization: NCTU CS >Environment: System: FreeBSD stucgi 7.0-RELEASE-p1 FreeBSD 7.0-RELEASE-p1 #0: Thu Apr 17 15:56:39 CST 2008 >Description: iscsi-target support many arguments such as "-t" for iscsi target name, but we couldn't just set variable like setting iscsi_target_flags="-t xxx" in /etc/rc.conf to customize it. The following patches add this support and fix warnings by portlint. Port maintainer (mark@foster.cc) is cc'd. Generated with FreeBSD Port Tools 0.77 >How-To-Repeat: >Fix: --- iscsi-target-20080207_2.patch begins here --- diff -ruN --exclude=CVS /usr/ports/net/iscsi-target/Makefile /amd/account/gcs/96/9655630/dev/ports/net/iscsi-target/Makefile --- /usr/ports/net/iscsi-target/Makefile 2008-05-03 21:39:28.000000000 +0800 +++ /amd/account/gcs/96/9655630/dev/ports/net/iscsi-target/Makefile 2008-07-21 22:29:12.000000000 +0800 @@ -11,7 +11,7 @@ CATEGORIES= net MASTER_SITES= ftp://ftp.netbsd.org/pub/pkgsrc/distfiles/ \ http://www.magnesium.net/~mdf/distfiles/ -PKGNAMESUFFIX= -target +PKGNAMESUFFIX= -target DISTNAME= netbsd-iscsi-${PORTVERSION} MAINTAINER= mark@foster.cc @@ -53,6 +53,6 @@ ${CP} -p ${PREFIX}/etc/iscsi/$i.sample ${PREFIX}/etc/iscsi/$i ; \ fi .endfor + @${CAT} ${PKGMESSAGE} .include <bsd.port.mk> - @${CAT} ${PKGMESSAGE} diff -ruN --exclude=CVS /usr/ports/net/iscsi-target/files/iscsi_target.in /amd/account/gcs/96/9655630/dev/ports/net/iscsi-target/files/iscsi_target.in --- /usr/ports/net/iscsi-target/files/iscsi_target.in 2006-10-07 23:25:26.000000000 +0800 +++ /amd/account/gcs/96/9655630/dev/ports/net/iscsi-target/files/iscsi_target.in 2008-07-21 22:17:34.000000000 +0800 @@ -8,15 +8,15 @@ name="iscsi_target" rcvar=`set_rcvar` -command="%%PREFIX%%/bin/iscsi-target" -required_files="%%PREFIX%%/etc/iscsi/targets" -pidfile="/var/run/iscsi-target.pid" - load_rc_config $name : ${iscsi_target_enable="NO"} : ${iscsi_target_config="%%PREFIX%%/etc/iscsi/targets"} +: ${iscsi_target_flags=""} -command_args="-f $iscsi_target_config" +command="%%PREFIX%%/bin/iscsi-target" +command_args="-f ${iscsi_target_config} ${iscsi_target_flags}" +required_files="${iscsi_target_config}" +pidfile="/var/run/iscsi-target.pid" run_rc_command "$1" --- iscsi-target-20080207_2.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200807211438.m6LEc05d004983>