From owner-cvs-ports@FreeBSD.ORG  Wed Mar 21 19:41:04 2012
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7ECEA1065673;
	Wed, 21 Mar 2012 19:41:04 +0000 (UTC)
	(envelope-from utisoft@gmail.com)
Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com
	[209.85.214.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 549BA8FC14;
	Wed, 21 Mar 2012 19:41:02 +0000 (UTC)
Received: by bkcjc3 with SMTP id jc3so1635984bkc.13
	for <multiple recipients>; Wed, 21 Mar 2012 12:41:02 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:sender:in-reply-to:references:from:date
	:x-google-sender-auth:message-id:subject:to:cc:content-type;
	bh=eygT2On5oydwIFqrMZeQA7+sDSsDC3E0Qm6XQMq+9Eg=;
	b=Jd9g81vTfcddJtK3daPJfEl+JzkpxM49pmwBwoYQwfFvz7VTIc5FdLL4SWNQGpjaMI
	WoG6/jVlaMyAT+a7dwLkTbQHtK4GAvAo5f7pGQB5VSipEDG4PrVvqYSZOMbFd+YMfyng
	PxLpT/4C460Po1PqRhbnfgsZvdbMYz7K65iA0yNDBz0gyFiIolUEj9onybewkiE+dqTj
	DKwB1Pnf/XjJf5s37sobDqI/V20b6jM24i5/1x2v6BSxRCxqF5QLnW1d/zRqxx50RJ0o
	KscOqAzn/2WyA3b6oss77zcWBxX8/sEQBgZnbHI5KO/ykkXBIQ/7JQVcao63ZDp1xXzn
	x8mg==
Received: by 10.204.156.217 with SMTP id y25mr2005688bkw.36.1332358862218;
	Wed, 21 Mar 2012 12:41:02 -0700 (PDT)
MIME-Version: 1.0
Sender: utisoft@gmail.com
Received: by 10.204.202.142 with HTTP; Wed, 21 Mar 2012 12:40:32 -0700 (PDT)
In-Reply-To: <20120320022942.GC27552@atarininja.org>
References: <201203191403.q2JE3sM8051201@repoman.freebsd.org>
	<20120319143041.GB27552@atarininja.org> <4F67438C.605@freebsd.org>
	<20120320022942.GC27552@atarininja.org>
From: Chris Rees <crees@freebsd.org>
Date: Wed, 21 Mar 2012 19:40:32 +0000
X-Google-Sender-Auth: tHTAhLcY3NRthYmupVRqyeIXXgI
Message-ID: <CADLo83854652Zo=3mnbYOYXQ8jZh1jfv8z7ueHuKBgL-cGsgcw@mail.gmail.com>
To: Wesley Shields <wxs@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: Michael Scheidell <scheidell@freebsd.org>, cvs-ports@freebsd.org,
	cvs-all@freebsd.org, ports-committers@freebsd.org
Subject: Re: cvs commit: ports/graphics/opennurbs Makefile pkg-plist
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Mar 2012 19:41:04 -0000

On 20 March 2012 02:29, Wesley Shields <wxs@freebsd.org> wrote:
> On Mon, Mar 19, 2012 at 10:32:44AM -0400, Michael Scheidell wrote:
>>
>>
>> On 3/19/12 10:30 AM, Wesley Shields wrote:
>> > Isn't it better to use ${INSTALL_DATA} here?
>> >
>> > -- WXS
>> open a pr, let maintainer approve it.
>
> As the person who committed this it is your responsibility to see that
> issues raised are properly fixed. If you feel like the maintainer should
> be brought in for such a simple change that is your decision to make,
> but I shouldn't have to open a PR to address this.
>
>> Id also like to see examples wrapper in a .if/endif and pkg-plist
>> prefixed with %%PORTEXAMPLES%%%EXAMPLES%% .
>
> Would be nice to have also, but not my point. Using ${INSTALL_DATA} is
> the right thing to do because it sets the owner and mode properly.

Actually, the code is completely incorrect because the do-install
target removes the files from WRKSRC, meaning that if you try to
install twice you have to re-extract and start all over again.

Please fix this, you should not dump code in the repo and tell other
people to fix your mistakes.

Chris