From owner-dev-commits-src-all@freebsd.org Tue Jan 12 04:04:28 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B10C34C804E; Tue, 12 Jan 2021 04:04:28 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-oi1-f182.google.com (mail-oi1-f182.google.com [209.85.167.182]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DFH5S4PHXz3sQY; Tue, 12 Jan 2021 04:04:28 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-oi1-f182.google.com with SMTP id w124so1007267oia.6; Mon, 11 Jan 2021 20:04:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ve1oIDFmO313rXw0dAjJVe9/sl6lvrygYmMpt14ZtIA=; b=F6GnOrTN9fOh2tNgEibMllnCAi/JLHHNu3b0G+UgdsdzIJjNs7S298/0Yy6V3uiLn8 GLd7IH/Pz7y56AtpuR92gGu346vV3uuC95GVfGxqdEkNJhgEUe+Q5ETYmLPeNY0YaNah GmLu8mb1iRE3QNCI4g9QcfvmGnRiGPQGP+3fnip2MPlsNsDOX0Ne0SVOjn+tCqxV07fP +d79XdQyllz7Hvripj9kQDvMwONeNImSE/Q79uUKg9FepwntEmBYME7vZKUKoYePyyQG 3+a/TNiHsN1AF3J3BgYQCxwjaNQ5aXcZbOF4A/KAMJbje4JC+u1nBtilh0nbw7P+p58W PkDg== X-Gm-Message-State: AOAM530SkMHCDCuutRhChwHaexwaoiuhkeypBWj67PuG4M+drCXARHsF P1CNswdrlbftjP7FyiZ5pyrhGQsBt03UgewKPl4E+ARkstY= X-Google-Smtp-Source: ABdhPJyJCeGjFK03g5bYTne81Nv3sPaVa2aq9O+xxclt3sBUSOFBKf1aPIwqaqnZ5sUJ9pb5f9tjsEDQhdzvMfLMJRM= X-Received: by 2002:aca:af8f:: with SMTP id y137mr1274788oie.55.1610424266674; Mon, 11 Jan 2021 20:04:26 -0800 (PST) MIME-Version: 1.0 References: <202101120210.10C2ADmg048698@gitrepo.freebsd.org> In-Reply-To: From: Alan Somers Date: Mon, 11 Jan 2021 21:04:15 -0700 Message-ID: Subject: Re: git: 292808246db7 - main - ICMP checksum test: Fix for big endian To: Ryan Libby Cc: src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org X-Rspamd-Queue-Id: 4DFH5S4PHXz3sQY X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jan 2021 04:04:28 -0000 On Mon, Jan 11, 2021 at 8:25 PM Ryan Libby wrote: > On Mon, Jan 11, 2021 at 6:10 PM Alan Somers wrote: > > > > The branch main has been updated by asomers: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=292808246db702b9194deb8938e40fd06914aea9 > > > > commit 292808246db702b9194deb8938e40fd06914aea9 > > Author: Charlie Root > > Hmm, did your git client fill in the author name that way? Since... > > > AuthorDate: 2021-01-12 01:56:12 +0000 > > Commit: Alan Somers > > CommitDate: 2021-01-12 02:03:46 +0000 > > > > ICMP checksum test: Fix for big endian > > > > The in_cksum tests originally tried to simulate a BE environment by > > swapping the byte order of the input. But that's overcomplicated, > and > > didn't actually work on real BE hardware. The correct testing > strategy > > is just to test on the native endianness, and run the tests in both > BE > > and LE environments. > > > > Submitted by: Renato Riolino < > renato.riolino@eldorado.org.br> > > ...given this submitted-by line, I am guessing it wasn't intended? > > > Reviewed By: asomers > > MFC after: 2 weeks > > Differential Revision: https://reviews.freebsd.org/D23193 > > --- > Well, Renato opened the PR on Phabricator. When I pulled in his patch, phabricator must've helpfully pulled in the author line, too. But the "Submitted by" line I wrote by hand. -Alan