From owner-freebsd-hackers Fri Aug 2 16:34:52 2002 Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5B06537B400 for ; Fri, 2 Aug 2002 16:34:47 -0700 (PDT) Received: from tungsten.btinternet.com (tungsten.btinternet.com [194.73.73.81]) by mx1.FreeBSD.org (Postfix) with ESMTP id CAE1543E6A for ; Fri, 2 Aug 2002 16:34:46 -0700 (PDT) (envelope-from dominic_marks@btinternet.com) Received: from host217-39-107-221.in-addr.btopenworld.com ([217.39.107.221] helo=btinternet.com) by tungsten.btinternet.com with esmtp (Exim 3.22 #8) id 17alwT-0005eu-00 for freebsd-hackers@freebsd.org; Sat, 03 Aug 2002 00:34:45 +0100 Message-ID: <3D4B1755.1030301@btinternet.com> Date: Sat, 03 Aug 2002 00:35:49 +0100 From: Dominic Marks User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.1b) Gecko/20020721 X-Accept-Language: en, en-us MIME-Version: 1.0 To: freebsd-hackers@freebsd.org Subject: very minor vm_map.c typo ? Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Hello, In vm_map.c, in the vm_map_insert(...) function there is the following piece of code which checks if the addresses supplied to the function are valid: ** if ((start < map->min_offset) || (end > map->max_offset) || (start >= end)) return (KERN_INVALID_ADDRESS); ** Specifically, I am interested in the final comparison. Is it possible that start == end could ever be correct? Do zero sized entries ever get inserted? (I don't see why you would ever wish to do this, please explain it to me if there is a reason). Normally I'd submit a PR about this but since its not an area of the code I am very familiar with I thought I'd ask. I would also supply a patch but for a one character change it seems pretty silly. Thanks, -- Dominic To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message