From owner-cvs-all  Mon Dec 16 15: 9:36 2002
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 27D3237B404
	for <cvs-all@freebsd.org>; Mon, 16 Dec 2002 15:09:35 -0800 (PST)
Received: from rootlabs.com (root.org [67.118.192.226])
	by mx1.FreeBSD.org (Postfix) with SMTP id E6E7743ED8
	for <cvs-all@freebsd.org>; Mon, 16 Dec 2002 15:09:33 -0800 (PST)
	(envelope-from nate@rootlabs.com)
Received: (qmail 47623 invoked by uid 1000); 16 Dec 2002 23:09:35 -0000
Date: Mon, 16 Dec 2002 15:09:35 -0800 (PST)
From: Nate Lawson <nate@root.org>
To: Julian Elischer <julian@FreeBSD.org>
Cc: cvs-all@freebsd.org, cvs-committers@freebsd.org
Subject: Re: cvs commit: src/sys/i386/i386 dump_machdep.c
In-Reply-To: <20021216230459.E8CBB37B436@hub.freebsd.org>
Message-ID: <Pine.BSF.4.21.0212161505500.47122-100000@root.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Mon, 16 Dec 2002, Julian Elischer wrote:
>   Modified files:
>     sys/i386/i386        dump_machdep.c 
>   Log:
>   Don't dump core into a partition that is too small for it.
>   If we do, we usually wrote backwareds into the proceeding partititon
>   which is usually the root partition.
> [..]
> @@ -75,6 +75,15 @@
>  		strncpy(kdh.panicstring, panicstr, sizeof kdh.panicstring);
>  	kdh.parity = kerneldump_parity(&kdh);
>  
> +	if (di->mediasize <  
> +	    ((Maxmem * (off_t)PAGE_SIZE) +	/* Memory to save */
> +	    (sizeof kdh * 2) +			/* header + trailer */
> +	    (64*1024)))	{			/* Room to leave untouched */
> +						/* at partition head. */
> +						/* (an arbitrary amount). */
> +		printf("\nDump failed. Partition too small.\n");
> +		return;
> +	}
>  	dumplo = di->mediaoffset + di->mediasize - Maxmem * (off_t)PAGE_SIZE;
>  	dumplo -= sizeof kdh * 2;
>  	i = di->dumper(di->priv, &kdh, 0, dumplo, sizeof kdh);

Heh, it seems you went even farther to tweak everyone that had style(9)
complaints with the proposal.  At the very least, PLEASE move the comment
to before the line.

Functionally, it is important that this check be MI.

-Nate


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message