Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 15 Apr 2017 09:30:49 +1000 (AEST)
From:      Gerald Pfeifer <gerald@pfeifer.com>
To:        Pedro Giffuni <pfg@FreeBSD.org>, freebsd.contact@marino.st
Cc:        Mark Millard <markmi@dsl-only.net>, freebsd-ports@freebsd.org,  freebsd-toolchain@freebsd.org, freebsd-arm@freebsd.org,  freebsd-head@freebsd.org, ericturgeon.bsd@gmail.com
Subject:   Re: lang/gcc6-aux for head beyond __nonnull related issues: vm_ooffset_t and vm_pindex_t related changes (and more)
Message-ID:  <alpine.LNX.2.21.1704150928320.4604@anthias.pfeifer.com>
In-Reply-To: <E86AC2D1-EE2D-4E33-85FD-8069B050421F@FreeBSD.org>
References:  <E54E495A-E4C8-40B3-B1E8-133A9872B6B2@dsl-only.net> <9758023E-1526-41F9-9416-6AC8AD3201B5@dsl-only.net> <E86AC2D1-EE2D-4E33-85FD-8069B050421F@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 13 Apr 2017, Pedro Giffuni wrote:
> I didn’t want to get into this but the problem is that as part of it's
> build/bootstrapping process, GCC historically takes system headers
> and attempts to “fix” them. I am unsure the fixes do anything at all
> nowadays but the effect is that the compiler tends to take snapshots
> of the system headers when it is built. cdefs.h is used by all the
> system headers so changes in cdefs.h have good chances affecting
> such builds but any change are likely to cause similar trouble.
> 
> In the case of gcc-aux, it appears the compilation is based on a
> bootstrap compiler which already carries outdated headers.
> A workaround, suggested by gerald@ the last time a similar issue
> happened was to run for install-tools/fixinc.sh. I think that may
> regenerate the headers and let the build use updated headers.
> Ultimately gcc-aux needs maintainer intervention and using
> outdated headers will break sooner or later: especially on -current.

Indeed, thanks for the analysis/background, Pedro!

I had a look at gcc6-aux is based on the 20170202 snapshot of GCC 6, 
and perhaps John (as the maintainer of that port) has plans to update 
it?  Let me copy him.

Gerald

PS: John, if you have an update, happy to help and apply that for you.
From owner-freebsd-ports@freebsd.org  Sat Apr 15 00:20:40 2017
Return-Path: <owner-freebsd-ports@freebsd.org>
Delivered-To: freebsd-ports@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 899BFD3D261;
 Sat, 15 Apr 2017 00:20:40 +0000 (UTC)
 (envelope-from kabaev@gmail.com)
Received: from mail-qk0-x244.google.com (mail-qk0-x244.google.com
 [IPv6:2607:f8b0:400d:c09::244])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4A94BE16;
 Sat, 15 Apr 2017 00:20:40 +0000 (UTC)
 (envelope-from kabaev@gmail.com)
Received: by mail-qk0-x244.google.com with SMTP id v75so13356708qkb.3;
 Fri, 14 Apr 2017 17:20:40 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version; bh=LlUPIyJB9UTXJENbMrNZQYTtVkJuUbKLv6uNX+kUc9U=;
 b=IJUNhbv/W6GEeZCXnh5Z1UDncLFVxfJJRLR6Bm+i/mp5CBKo0bllRi8rSkfAdvxCrq
 sT9Y5lO3jwV7oGu4KxpQ0D+8Tebft0PnI/6WfF+AKg6+6JtAPDZV3XOWsjcsvXID/Db0
 EKhQuSYocWV62CVU/vseF4UI02JTFKEOV5CIgJ9Zv7aYyQxEIhVIZjGyb/tsTNCnnam9
 F0/hjcGQecD7e1O0hxYXV9lZeFormeM3HNAhQsBC6owDgPsESlXeI2ge2X3bmamtUWlf
 OJ0FR84+cu2aGim6tufyBNmyzb4H7LyYzq6WNwyYYwSZO0IypmIp8jz2/IiPXP7oAqgY
 fQSA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version;
 bh=LlUPIyJB9UTXJENbMrNZQYTtVkJuUbKLv6uNX+kUc9U=;
 b=sc0dUNc9aJRQDoQEna/sipNpB0CV91eq+bqqxLmUPATvVqA/Fdn1XEfF6sCOS6ebLc
 biKIW8DFuPwU600MM/6FqLCgQWj3UKmfmh8ox6IgAiIbfop3dL1uOTYm+3tG0o2fbRWV
 7y8UFmaak1YWD5LYL8LxP5FP6e8Mz9WB1hLfnPBRIoXIlUplSE55AVLgHw02i+45jq63
 gLMh5arHqgolDdQ0XQGSfDBuiu94ZE7fTSoxhF8fH2RWSzvtXHVxNtMo3Q706fPPvhMI
 vtynzqUJ7WRWh4MwRijxgJWr9us/e5e/KuBnv0/pgSClktK7m3n55dZTgxftLB6Ikhwi
 rjKg==
X-Gm-Message-State: AN3rC/6w45kaU+bUb7XNCl171n0BuYYwulJ35a5+pduXg4nsdPLUuPtJ
 HEg2/TjqcAa2t5OY5O0=
X-Received: by 10.55.157.3 with SMTP id g3mr161757qke.30.1492215639419;
 Fri, 14 Apr 2017 17:20:39 -0700 (PDT)
Received: from kan ([2601:18f:802:4680:226:18ff:fe00:232e])
 by smtp.gmail.com with ESMTPSA id t40sm2238368qtb.6.2017.04.14.17.20.37
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Fri, 14 Apr 2017 17:20:38 -0700 (PDT)
Date: Fri, 14 Apr 2017 20:20:28 -0400
From: Alexander Kabaev <kabaev@gmail.com>
To: Gerald Pfeifer <gerald@pfeifer.com>
Cc: Pedro Giffuni <pfg@FreeBSD.org>, freebsd-ports@freebsd.org,
 freebsd-toolchain@freebsd.org
Subject: Re: lang/gcc6-aux for head beyond __nonnull related issues:
 vm_ooffset_t and vm_pindex_t related changes (and more)
Message-ID: <20170414201952.69ccc472@kan>
In-Reply-To: <alpine.LNX.2.21.1704150928320.4604@anthias.pfeifer.com>
References: <E54E495A-E4C8-40B3-B1E8-133A9872B6B2@dsl-only.net>
 <9758023E-1526-41F9-9416-6AC8AD3201B5@dsl-only.net>
 <E86AC2D1-EE2D-4E33-85FD-8069B050421F@FreeBSD.org>
 <alpine.LNX.2.21.1704150928320.4604@anthias.pfeifer.com>
X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.29; amd64-portbld-freebsd12.0)
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
 boundary="Sig_/hXT+0F0LpnBeyNBKZqTkMUr"; protocol="application/pgp-signature"
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports/>;
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 15 Apr 2017 00:20:40 -0000

--Sig_/hXT+0F0LpnBeyNBKZqTkMUr
Content-Type: text/plain; charset=KOI8-R
Content-Transfer-Encoding: quoted-printable

On Sat, 15 Apr 2017 09:30:49 +1000 (AEST)
Gerald Pfeifer <gerald@pfeifer.com> wrote:

> On Thu, 13 Apr 2017, Pedro Giffuni wrote:
> > I didn't want to get into this but the problem is that as part of
> > it's build/bootstrapping process, GCC historically takes system
> > headers and attempts to "fix" them. I am unsure the fixes do
> > anything at all nowadays but the effect is that the compiler tends
> > to take snapshots of the system headers when it is built. cdefs.h
> > is used by all the system headers so changes in cdefs.h have good
> > chances affecting such builds but any change are likely to cause
> > similar trouble.
> >=20
> > In the case of gcc-aux, it appears the compilation is based on a
> > bootstrap compiler which already carries outdated headers.
> > A workaround, suggested by gerald@ the last time a similar issue
> > happened was to run for install-tools/fixinc.sh. I think that may
> > regenerate the headers and let the build use updated headers.
> > Ultimately gcc-aux needs maintainer intervention and using
> > outdated headers will break sooner or later: especially on
> > -current. =20
>=20
> Indeed, thanks for the analysis/background, Pedro!
>=20
> I had a look at gcc6-aux is based on the 20170202 snapshot of GCC 6,=20
> and perhaps John (as the maintainer of that port) has plans to update=20
> it?  Let me copy him.
>=20
> Gerald
>=20
> PS: John, if you have an update, happy to help and apply that for you.

Hi Gerald,

it was suggested multiple times that the whole fixinc step is
ultimately harmful and serves no useful purpose and probably should be
disabled in built packages outright. Is there a reason not to do it?
Even Redhat appears to do the slimming in their rpms:

mv $FULLPATH/include-fixed/syslimits.h $FULLPATH/include/syslimits.h
mv $FULLPATH/include-fixed/limits.h $FULLPATH/include/limits.h
for h in `find $FULLPATH/include -name \*.h`; do
  if grep -q 'It has been auto-edited by fixincludes from' $h; then
    rh=3D`grep -A2 'It has been auto-edited by fixincludes from' $h |
tail -1 | sed 's|^.*"\(.*\)".*$|\1|'` diff -up $rh $h || :
    rm -f $h
  fi
done

--=20
Alexander Kabaev

--Sig_/hXT+0F0LpnBeyNBKZqTkMUr
Content-Type: application/pgp-signature
Content-Description: Цифровая подпись OpenPGP

-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEExffZlZm2QeE8UVaRBxMimZJ5Ln4FAljxZ0xfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEM1
RjdEOTk1OTlCNjQxRTEzQzUxNTY5MTA3MTMyMjk5OTI3OTJFN0UACgkQBxMimZJ5
Ln45nBAA1N6Du8J21LqGNKP37WTWqn6fLUeZaI9COJWPkVexi8Lb3bSuWA9KkuU5
vv/R57g4W21GaVuqI/6yRRCq6TFXpW+iXojxVbV2V1ix0U2hr0xPU7CLKk9LYnsk
DHpbV8EVMSHYtuV188Ap2lqFJyXAOIn/s0Ymt/icz2HXyVpvpJ7PzhLQUZsjYnh/
J3WuJCAwBZA3F1LXKtl/a3iweiGpuxuOWfsYlwO6eTZerCop33qsLyq9UdPs6EEF
z+KV1O08GzFh75wjtUlYSRTtX3N5EmoUivYHKUDwEJX3K7wPv4AUpyVmtpMnu+ns
lc0nz7bErkhduoptEALbMpbyXfTdkiGc+hO9GpuTKYAgNcQTWMa9j7k9KY74WoDm
T6vDXRg8VvyIQTyvl1cko+9nkTWXVsG5JR+uP5+ED27N9lwCEMDUccvm6qy/HKzc
vE2gZzEtiNv9pd1S1OPyLJ2PNDGvoMVmjRIAU5lVLomLoyA69u/og/99Vyu+rGL4
Mb/+CLh+2i8M4cxTU99IR8/mJ+6qKDftaLBbRs/d+8F+8NomIdO2ioNu/+qcsddK
fecmPyjanPd7+2KHrHqSCJw3GG3NhMRYy10konRRsM6MAfdU/1/HgwgbwDemxTkO
ZV7CbctNwNxsprrBbHtmInPhJ94AJ59x+8RQ9NO00gI+YNwaSvw=
=bti7
-----END PGP SIGNATURE-----

--Sig_/hXT+0F0LpnBeyNBKZqTkMUr--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.LNX.2.21.1704150928320.4604>