Date: Wed, 17 Nov 2004 11:58:11 +0100 From: Jose M Rodriguez <josemi@freebsd.jazztel.es> To: Michael Johnson <ahze@ahze.net> Cc: freebsd-gnome@freebsd.org Subject: Re: About firefox new layout Message-ID: <200411171158.11611.freebsd@redesjm.local> In-Reply-To: <66E1C082-387E-11D9-8B95-000A95BB7150@ahze.net> References: <200411170947.45235.freebsd@redesjm.local> <66E1C082-387E-11D9-8B95-000A95BB7150@ahze.net>
next in thread | previous in thread | raw e-mail | index | archive | help
El Mi=E9rcoles, 17 de Noviembre de 2004 10:52, Michael Johnson escribi=F3:
> On Nov 17, 2004, at 3:47 AM, Jose M Rodriguez wrote:
> > El Mi=E9rcoles, 17 de Noviembre de 2004 05:52, Joe Marcus Clarke
> >
> > escribi=F3:
> >> Jose M Rodriguez wrote:
>
> ---- snip ----
> [...]
> >> | This must be not only easier, but also safer.
>
> how is this easier and safer?
>
The most common way to install firefox is with firefox[-config] and=20
run-mozilla.sh in the same dir. This is the most proven layout from=20
the mozilla comunity.
Doing that, we don't need ${FILESDIR}/patch-browser_app_mozilla.in. And=20
this really correct a bug.
Also, you may compare /usr/X11R6/bin/mozilla with /usr/X11R6/bin/firefox
At last here, doing the same or even more, I feel safer with mozilla=20
way.
=2D You don't need to patch mainstream mozilla dist.
=2D It's smaller and more clean.
At a minimus, even a simple firefox like:
#!/bin/sh
#
exec /usr/X11R6/lib/firefox/firefox
Wil get you a more proven way to launch firefox
> >> | 3) problems with OpenURL()
> >> |
> >> | Now, we use a simple REMOTE OpenURL(${url}) that overwrite the
> >> | displaying page. We use a REMOTE OpenURL(${url},new-tab) in
> >> | mozilla. we'll use some kinda of MOZILLA_OpenURL_LOC env in
> >> | firefox/mozilla with the same feel.
> >>
> >> Is there a question in here?
> >
> > my version of /usr/X11/bin/firefox right now is attached. But I'm
> > not sure 100%. seems that firefox have config to alter the behavior
> > of OpenURL(<url>).
> >
> > In any way I'll prefer:
> > - drop ${FILESDIR}/patch-browser_app_mozilla.in (patch is not
> > needed)
>
> you submitted the patch =3DP
Yes. And later see the layout change.
The patch is correct. What I'm talking is about move this stuff to a=20
previous script and link both through exec if not using REMOTE.
So we have our FreeBSD related stuff in ${PREFIX}/bin/firefox and the=20
mainstream mozilla stuff (without patches) in=20
${PREFIX}/lib/firefox/firefox
>
> > - install firefox[-config] under ${PREFIX}/lib/firefox
>
> Why install firefox[-config] in PREFIX/lib/firefox?
> I don't see any reason to do this. It's not like we have
> www/firefox-devel or anything
> that would conflict.
Please, read above and see how ${PREFIX}/bin/mozilla and=20
${PREFIX}/lib/mozilla/mozilla work in the same way.
>
> > - install a brand new ${FILESDIR}/firefox.sh as
> > ${PREFIX}/bin/firefox
>
> So basically the only thing you want is when you open 2 sessions of
> firefox the
> 2nd session doesn't open but opens a new tab?
>
Not really. This may be taken with or without script split.
I can send-pr to what is prefer:
=2D more patching to patch-browser_app_mozilla.in
=2D script split.
Also, if we go to script split, this must reach thunderbird also.
> Michael
=2D-
josemi
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200411171158.11611.freebsd>