From nobody Wed Jun 3 20:23:20 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gVzfh1xVbz6gfKK; Wed, 03 Jun 2026 20:23:24 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gVzfg72Rhz3Fgw; Wed, 03 Jun 2026 20:23:23 +0000 (UTC) (envelope-from glebius@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780518204; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6EiGi9JUC2ARvcP8yZ0d2U8ViRPy6IyEKwVjbcy8A4g=; b=UwsviUN6XIj4zGQmrLd8l9c2a3b165sHCFWtAenEULqfJEzsY7ncuiJkDiG7t/XUf6vhVp QxDm79//7Y/5WBXjLMYraPGjGH3l5KdcjNFxtUYjLpIIE8vWU5gC32XDCv+JYN+3jwlu9z xaUIUwLwPYVYk+UWvHKIYU/szE0/52IIP1OsFLIM4XXs23Ot1lKZI7sgepxFsiCWCOHGbU X4lzGx6BKcpvEekt8k9rQ26s9LeN2GfLbKKwP7+xMRsoD/3ImrKxvHe6WQNJzXimCBodgM J2JIXNNUIRaVqEXZpIiWJFydkY3zpNKv7XslF6iY/2bcJAYgo6JxzW0bZcybcQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1780518204; a=rsa-sha256; cv=none; b=xkGQJPHdyItnuYyFbXK8HmHs8e2zJNgaDtuA7oV17+V2KttfE3scHeT+j3A+oC/g0vY/ob ud9B6P/R4mkunrT7ZjolxWYNAqWPRyWRpAwPAY3eBQJjL0kM5RZpjoZd8SfNRYSRhMPz18 ilPAqy3aBeE4PZWCamzWz+2GuhtfA4rC0E9jYn5bJqio6QMElFTOKnQArE2kSwxpRj5DeF NwSmEzUZxd1sJmSwQUCJDnlF4KPKIGw+EEvMS62PQSc7OH1pncjbRNyfANmgDyu3XteWZK m97YPDorerwOVV5UinwjamZkU26vzP3jKY8jMzyiRfLQwq7xI1N8tc0zz2Wmrw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780518204; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6EiGi9JUC2ARvcP8yZ0d2U8ViRPy6IyEKwVjbcy8A4g=; b=gREANEJ84rAkM58ueKQyvHll9P5FvBW5ykaoWOvFZS68byLP8MIlnY/ga4xDjEaN3z5Jwq svGVVmtBAN7XN2si9C4Cl/Px1TOEieMzn6lSRgzbJSKcERorby8Tf7GQe+4A+Bg26FpLOm eXe0J1U4ga2leQrb/s4fgyB9Ul6ca5r/Uj5NSpORTPLL+uL4TLO+6sfH7MA+9/cS7mg9CA nXbCknRllf5EWIH3KFhCjoTT5KLmP1zuf9/EhcBdhXC6LKWPYeIfM4MNNoTmLXaLT2Fvx6 W4js9UXFX4YK53MalUumK1ODH0F15nE4FDVh65WSVEODHYabFg4b1+eAu3mj5w== Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: glebius) by smtp.freebsd.org (Postfix) with ESMTPSA id 4gVzfg1Dh9zQWT; Wed, 03 Jun 2026 20:23:23 +0000 (UTC) (envelope-from glebius@freebsd.org) Date: Wed, 3 Jun 2026 13:23:20 -0700 From: Gleb Smirnoff To: Kristof Provost Cc: Ishan Agrawal , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 017690e50913 - main - netpfil: add PF netlink command decoding support Message-ID: References: <6a2028fd.30559.3287a30@gitrepo.freebsd.org> <03F81E99-0A9B-4265-951B-0177AC8ADA80@FreeBSD.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <03F81E99-0A9B-4265-951B-0177AC8ADA80@FreeBSD.org> On Wed, Jun 03, 2026 at 10:18:48PM +0200, Kristof Provost wrote: K> On 3 Jun 2026, at 22:08, Gleb Smirnoff wrote: K> > On Wed, Jun 03, 2026 at 01:15:41PM +0000, Kristof Provost wrote: K> > K> The branch main has been updated by kp: K> > K> K> > K> URL: https://cgit.FreeBSD.org/src/commit/?id=017690e509134422dbfa80316eab56d8d3f87065 K> > K> K> > K> commit 017690e509134422dbfa80316eab56d8d3f87065 K> > K> Author: Ishan Agrawal K> > K> AuthorDate: 2026-06-01 12:24:05 +0000 K> > K> Commit: Kristof Provost K> > K> CommitDate: 2026-06-03 08:52:06 +0000 K> > K> K> > K> netpfil: add PF netlink command decoding support K> > K> K> > K> Convert PFNL_CMD values in pf_nl.h from an enum to #define constants, K> > K> add a pfnl_cmd table definition for mktable, and implement the K> > K> corresponding command decoding helpers in libsysdecode. K> > K> K> > K> This allows mktable to generate PF netlink command lookup tables and K> > K> enables symbolic decoding of PF netlink commands. K> > K> K> > K> Reviewed by: kp K> > K> Signed-off-by: Ishan Agrawal K> > K> Sponsored by: Google LLC (GSoC 2026) K> > K> > Sorry for not reviewing in time. I got question: why does this K> > require ditching the enum and regressing down to preprocessor K> > defines? K> > K> The mktables script in libsysdecode expects to work on defines: https://github.com/freebsd/freebsd-src/blob/07d733963ecd1957999f5381b438b8c369686750/lib/libsysdecode/mktables#L76 K> K> It’s possible to change that, but this being an enum doesn’t really buy us much either, and this was the less invasive path. Mkay, I will see if anything can be done there. -- Gleb Smirnoff