From owner-cvs-src@FreeBSD.ORG  Fri May 12 06:52:37 2006
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@freebsd.org
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 6949F16A400
	for <cvs-src@freebsd.org>; Fri, 12 May 2006 06:52:37 +0000 (UTC)
	(envelope-from joerg@britannica.bec.de)
Received: from hydra.bec.de (www.ostsee-abc.de [62.206.222.50])
	by mx1.FreeBSD.org (Postfix) with ESMTP id F2E9C43D46
	for <cvs-src@freebsd.org>; Fri, 12 May 2006 06:52:36 +0000 (GMT)
	(envelope-from joerg@britannica.bec.de)
Received: from britannica.bec.de (wlan032044.uni-rostock.de [139.30.32.44])
	by hydra.bec.de (Postfix) with ESMTP id 74DCF35707
	for <cvs-src@freebsd.org>; Fri, 12 May 2006 08:52:35 +0200 (CEST)
Received: by britannica.bec.de (Postfix, from userid 1000)
	id B414E6C572; Fri, 12 May 2006 08:52:17 +0200 (CEST)
Date: Fri, 12 May 2006 08:52:17 +0200
From: joerg@britannica.bec.de
To: cvs-src@freebsd.org
Message-ID: <20060512065217.GA1597@britannica.bec.de>
References: <200605110910.k4B9AYK5065047@repoman.freebsd.org>
	<20060511224018.J54716@mp2.macomnet.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20060511224018.J54716@mp2.macomnet.net>
User-Agent: Mutt/1.5.11
Subject: Re: cvs commit: src/lib/libc/gen syslog.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 12 May 2006 06:52:37 -0000

On Thu, May 11, 2006 at 10:41:37PM +0400, Maxim Konovalov wrote:
> On Thu, 11 May 2006, 09:10-0000, David Xu wrote:
> 
> > davidxu     2006-05-11 09:10:33 UTC
> >
> >   FreeBSD src repository
> >
> >   Modified files:
> >     lib/libc/gen         syslog.c
> >   Log:
> >   Save errno before calling pthread_mutex_lock because pthread_mutex_lock
> >   may change errno unexpectly.
> 
> AFAIR POSIX's pthread_* don't change errno.  Is it a bug in our
> implementation?

I agree that SUS doesn't specify any case where pthread_mutex_lock can
change errno. The major difference is that those functions return the
error directly.

Joerg