From owner-freebsd-stable@FreeBSD.ORG Fri Mar 16 01:07:02 2012 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7F2AC106564A for ; Fri, 16 Mar 2012 01:07:02 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from mail-pz0-f54.google.com (mail-pz0-f54.google.com [209.85.210.54]) by mx1.freebsd.org (Postfix) with ESMTP id 4E0438FC0A for ; Fri, 16 Mar 2012 01:07:02 +0000 (UTC) Received: by dald2 with SMTP id d2so5541644dal.13 for ; Thu, 15 Mar 2012 18:07:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=VQ3addp3CRSD5c7yib5enW5v/dw3wRZxC+WkDarCZ3c=; b=cA+5ypEdxT2sNoIA2hp5U/Xp2xnFLWbgNVRtiPq94Re/Pc69Wt1WbymbhFdDOz5VHM YWRpovB+z1k7HcGO3EvFnpU3BRAaVmheLg7vuuD8FrYP5ZvlKTXJt8IEU168DqePNj9e fCzmYKkOxjOHKWhTKINgpSHnR+9N3P8SlatXYc3cc/MLtaTpd34es4sCP7w3ALUQ3tzG TyLj7HAfdGYWrCQofUwYR4joK+Tbvurub2fklmHmeg1/lrvuLKHBPfm4i3WxHr0EAPkR y9+AYx+AffuSug6qrZrr8jSa5YrumBPNuwjp+e2nCsJXloVSAmFg5SS7FzZd1yM97agP zJ5A== Received: by 10.68.238.1 with SMTP id vg1mr9503199pbc.33.1331860021841; Thu, 15 Mar 2012 18:07:01 -0700 (PDT) Received: from pyunyh@gmail.com ([114.111.62.249]) by mx.google.com with ESMTPS id s1sm3008898pbs.21.2012.03.15.18.06.59 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 15 Mar 2012 18:07:00 -0700 (PDT) Received: by pyunyh@gmail.com (sSMTP sendmail emulation); Fri, 16 Mar 2012 10:06:51 -0700 From: YongHyeon PYUN Date: Fri, 16 Mar 2012 10:06:50 -0700 To: Paul Guyot Message-ID: <20120316170650.GA6841@michelle.cdnetworks.com> References: <8D3993D8-074E-45E6-8AF7-DB51369F33BD@ieee.org> <20120315171018.GA3295@michelle.cdnetworks.com> <3D1680C7-39A2-47B9-BD40-A987238886EB@ieee.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="+QahgC5+KEYLbs62" Content-Disposition: inline In-Reply-To: <3D1680C7-39A2-47B9-BD40-A987238886EB@ieee.org> User-Agent: Mutt/1.4.2.3i Cc: freebsd-stable@freebsd.org Subject: Re: Changes brought to bce(4) disabling ipmi access during boot X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Mar 2012 01:07:02 -0000 --+QahgC5+KEYLbs62 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Mar 15, 2012 at 09:19:27AM +0100, Paul Guyot wrote: > Le 15 mars 2012 ? 18:10, YongHyeon PYUN a ?crit : > > > On Wed, Mar 14, 2012 at 11:44:37PM +0100, Paul Guyot wrote: > >> Hello, > >> > >> Changes brought to bce(4) prevents booting a R410 Dell server with GELI-encrypted root ZFS partition requiring a passphrase, something that was possible with 9-RELEASE. > >> > >> Using a binary search, the bug comes from the following revision: > >> > >> Updating collection src-all/cvs > >> Edit src/sys/dev/bce/if_bce.c > >> Add delta 1.89.2.4 2012.01.09.19.07.14 yongari > >> Edit src/sys/dev/bce/if_bcereg.h > >> Add delta 1.35.2.3 2012.01.09.19.07.14 yongari > >> Shutting down connection to server > >> > > > > Could you try attach patch and let me know whether it recovers IPMI > > functionality? > > Thank you for your quick patch. Unfortunately, it does not recover IPMI functionality with STABLE@2012.01.09.19.08.00. > Hmm, how about this one? --+QahgC5+KEYLbs62 Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="bce.ipmi.diff2" Index: sys/dev/bce/if_bce.c =================================================================== --- sys/dev/bce/if_bce.c (revision 232950) +++ sys/dev/bce/if_bce.c (working copy) @@ -1992,8 +1992,7 @@ ifp = sc->bce_ifp; mii = device_get_softc(sc->bce_miibus); - if (mii == NULL || ifp == NULL || - (ifp->if_drv_flags & IFF_DRV_RUNNING) == 0) + if (mii == NULL || ifp == NULL) return; sc->bce_link_up = FALSE; @@ -2038,9 +2037,6 @@ } } - if (sc->bce_link_up == FALSE) - return; - /* Set half or full duplex based on PHY settings. */ if ((mii->mii_media_active & IFM_GMASK) == IFM_HDX) { DBPRINT(sc, BCE_INFO_PHY, --+QahgC5+KEYLbs62--