From owner-freebsd-current@FreeBSD.ORG Tue Sep 5 19:57:16 2006 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 23FD516A4DA for ; Tue, 5 Sep 2006 19:57:16 +0000 (UTC) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id A4B7043DFC for ; Tue, 5 Sep 2006 19:56:16 +0000 (GMT) (envelope-from andre@freebsd.org) Received: (qmail 35418 invoked from network); 5 Sep 2006 19:41:20 -0000 Received: from c00l3r.networx.ch (HELO [127.0.0.1]) ([62.48.2.2]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 5 Sep 2006 19:41:20 -0000 Message-ID: <44FDD65C.6070109@freebsd.org> Date: Tue, 05 Sep 2006 21:56:12 +0200 From: Andre Oppermann User-Agent: Thunderbird 1.5.0.5 (Windows/20060719) MIME-Version: 1.0 To: Prafulla Deuskar References: <2a41acea0609011551v40338539u4eef48d091dd12ab@mail.gmail.com> <44F9384C.9070902@freebsd.org> <2a41acea0609021741y481a04c0r42902166eaba78d7@mail.gmail.com> <20060905162542.GA63869@hub.freebsd.org> <44FDAF08.20407@freebsd.org> <20060905182313.GA85389@hub.freebsd.org> In-Reply-To: <20060905182313.GA85389@hub.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-net , freebsd-current , Jack Vogel Subject: Re: RFC: TSO patch for current X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Sep 2006 19:57:16 -0000 Prafulla Deuskar wrote: > Andre Oppermann [andre@freebsd.org] wrote: >> Prafulla Deuskar wrote: >>> Jack Vogel [jfvogel@gmail.com] wrote: >>> >>>> On 9/2/06, Andre Oppermann wrote: >>>> >>>> >>>>> I can't comment on the em part but the tcp_output.c stuff looks >>>>> very much like a straight port from NetBSD. If we take code from >>>>> the other BSDs we have to remark this in the emails we send with >>>>> patches and the commit message (otherwise we get accused of 'stealing >>>>> without attribution'). >>>> I dont know that I'd call it a straight port, rather I was working from >>>> some >>>> prototype code that Prafulla had working back on 4.7, but I think at that >>>> time that he may have patterned it after NetBSD. >>> I don't think NetBSD had TSO support in 2002 when I first did the 4.7 >>> patch for internal testing. >> OK, perhaps they lifted it from your patch then. They just looks awfully >> similiar that's why I thought it came from NetBSD. >> > Your patch looks good and is the way to go. > > So after Jack confirms that your patch works with the em driver > would you commit to to -current? Absolutely. :-) > The driver related changes can follow.. > > Later we also need to fix ifconfig so that user can enable/disable TSO on the interface. I'll do that together with the TSO code. -- Andre