From owner-svn-ports-head@freebsd.org  Sat Apr  2 22:01:31 2016
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id C6123AEC486;
 Sat,  2 Apr 2016 22:01:31 +0000 (UTC) (envelope-from adamw@adamw.org)
Received: from apnoea.adamw.org (apnoea.adamw.org [204.109.59.150])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "apnoea.adamw.org",
 Issuer "Let's Encrypt Authority X1" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4AA6C1A78;
 Sat,  2 Apr 2016 22:01:30 +0000 (UTC) (envelope-from adamw@adamw.org)
Received: by apnoea.adamw.org (OpenSMTPD) with ESMTPSA id 5da77a66
 TLS version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO;
 Sat, 2 Apr 2016 16:01:26 -0600 (MDT)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
Subject: Re: svn commit: r412432 - in head/security: . tls-check
 tls-check/files
From: Adam Weinberger <adamw@adamw.org>
In-Reply-To: <201604022014.u32KETWm022294@repo.freebsd.org>
Date: Sat, 2 Apr 2016 16:01:25 -0600
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <04948F99-1E02-48A1-9735-E5DA156959EA@adamw.org>
References: <201604022014.u32KETWm022294@repo.freebsd.org>
To: Kurt Jaeger <pi@FreeBSD.org>
X-Mailer: Apple Mail (2.3124)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 02 Apr 2016 22:01:31 -0000

> On 2 Apr, 2016, at 14:14, Kurt Jaeger <pi@FreeBSD.org> wrote:
>=20
> Author: pi
> Date: Sat Apr  2 20:14:29 2016
> New Revision: 412432
> URL: https://svnweb.freebsd.org/changeset/ports/412432
>=20
> +		p5-Test-Deep>=3D1.120:devel/p5-Test-Deep \
> +		p5-Test-Differences>=3D0.630:devel/p5-Test-Differences \
> +		p5-Test-Exception>=3D0.43:devel/p5-Test-Exception \
> +		p5-Test-File>=3D1.44:devel/p5-Test-File \
> +		p5-Test-MockObject>=3D1.20150527:devel/p5-Test-MockObject =
\
> +		p5-Test-Pod>=3D1.51:devel/p5-Test-Pod \
> +		p5-Test-Pod-Coverage>=3D1.10:devel/p5-Test-Pod-Coverage =
\
> +		p5-Test-Perl-Critic>=3D1.03:textproc/p5-Test-Perl-Critic =
\
> +		p5-Test-LWP-UserAgent>=3D0.030:www/p5-Test-LWP-UserAgent

Hi Kurt,

Every one of these p5-Test-* dependencies can be moved to TEST_DEPENDS. =
None is required to build or run the port. Additionally, p5-Test-Pod, =
p5-Test-Pod-Coverage, and p5-Test-Perl-Critic are almost always =
author-only tests and not intended to be run by end-users.

Also, GH_ACCOUNT already defaults to ${PORTNAME} and can be removed, and =
if you add DISTVERSIONSUFFIX=3D-Release then you can remove the need to =
track GH_TAGNAME.

# Adam


--=20
Adam Weinberger
adamw@adamw.org
http://www.adamw.org