From owner-svn-src-head@FreeBSD.ORG  Tue Nov 11 10:02:41 2014
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 90A6792D;
 Tue, 11 Nov 2014 10:02:41 +0000 (UTC)
Received: from smtp.des.no (smtp.des.no [194.63.250.102])
 by mx1.freebsd.org (Postfix) with ESMTP id 50E2F12B;
 Tue, 11 Nov 2014 10:02:40 +0000 (UTC)
Received: from nine.des.no (smtp.des.no [194.63.250.102])
 by smtp-int.des.no (Postfix) with ESMTP id 26D64AE96;
 Tue, 11 Nov 2014 10:02:34 +0000 (UTC)
Received: by nine.des.no (Postfix, from userid 1001)
 id 03491161B; Tue, 11 Nov 2014 11:02:32 +0100 (CET)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: "Bjoern A. Zeeb" <bz@FreeBSD.org>
Subject: Re: svn commit: r274340 - in head/sys: crypto/rijndael dev/random
 geom/bde
References: <201411100944.sAA9icnN061962@svn.freebsd.org>
 <3C962D07-3AAF-42EA-9D3E-D8F6D9A812B0@FreeBSD.org>
Date: Tue, 11 Nov 2014 11:02:32 +0100
In-Reply-To: <3C962D07-3AAF-42EA-9D3E-D8F6D9A812B0@FreeBSD.org> (Bjoern
 A. Zeeb's message of "Mon, 10 Nov 2014 15:10:36 +0000")
Message-ID: <86sihq5a2v.fsf@nine.des.no>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Nov 2014 10:02:41 -0000

"Bjoern A. Zeeb" <bz@FreeBSD.org> writes:
> This fails to compile on all gcc platforms.
>
> cc1: warnings being treated as errors
> /scratch/tmp/bz/head.svn/sys/modules/geom/geom_bde/../../../crypto/rijnda=
el/rijndael-api-fst.c:
> In function 'rijndael_padEncrypt':
> /scratch/tmp/bz/head.svn/sys/modules/geom/geom_bde/../../../crypto/rijnda=
el/rijndael-api-fst.c:236:
> warning: cast discards qualifiers from pointer target type
> [...]

The code is quite clearly wrong.  Why doesn't clang complain?

I'll commit dim@'s fix.  Thank you.

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no