From owner-freebsd-gnome@FreeBSD.ORG Thu Mar 3 23:43:48 2005 Return-Path: Delivered-To: freebsd-gnome@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4EF1916A4CE for ; Thu, 3 Mar 2005 23:43:48 +0000 (GMT) Received: from creme-brulee.marcuscom.com (creme-brulee.marcuscom.com [24.172.16.118]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8C15743D49 for ; Thu, 3 Mar 2005 23:43:47 +0000 (GMT) (envelope-from marcus@marcuscom.com) Received: from [10.2.1.2] (vpn-client-2.marcuscom.com [10.2.1.2]) j23NiO6K086824; Thu, 3 Mar 2005 18:44:24 -0500 (EST) (envelope-from marcus@marcuscom.com) Message-ID: <4227A132.40704@marcuscom.com> Date: Thu, 03 Mar 2005 18:43:46 -0500 From: Joe Marcus Clarke Organization: MarcusCom, Inc. User-Agent: Mozilla Thunderbird 1.0 (Macintosh/20041206) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Dejan Lesjak References: <200502282003.35926.dejan.lesjak@ijs.si> <200503020625.06322.dejan.lesjak@ijs.si> <1109744235.9751.8.camel@shumai.marcuscom.com> <200503040041.07369.dejan.lesjak@ijs.si> In-Reply-To: <200503040041.07369.dejan.lesjak@ijs.si> X-Enigmail-Version: 0.89.5.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.9 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.0.2 X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on creme-brulee.marcuscom.com cc: freebsd-gnome@freebsd.org Subject: Re: Freetype 2.1.9, Mozilla and Firefox [was Re: mozilla app patches] X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Mar 2005 23:43:48 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Dejan Lesjak wrote: | On Wednesday 02 of March 2005 07:17, Joe Marcus Clarke wrote: | |>On Wed, 2005-03-02 at 06:25 +0100, Dejan Lesjak wrote: |> |>>Mozilla needs: |>>http://www.ijs.si/~lesi/other/moz/patch-bugzilla149334 |>>http://www.ijs.si/~lesi/other/moz/patch-layout::svg::renderer::src::libar |>>t::nsSVGLibartGlyphMetricsFT.cpp |> |>How does this clash with extra-patch-nsSVGLibartGlyphMetricsFT.cpp |>needed to build Mozilla on 4.X? | | | The patch itself doesn't clash, but the result didn't build on 4.x. After | discussion with ahze on irc, there are now two extra patches instead. | | |>>Patch for www/mozilla: |>>http://www.ijs.si/~lesi/other/moz/mozillaport-freetype219.diff |>>www/firefox: |>>http://www.ijs.si/~lesi/other/moz/firefoxport-freetype219.diff |>> |>>Let me know if these are useful, I'll stuff them in PRs :) |> |>Definitely. If you throw these in a PR with your 2.1.9 patch (I'd like |>to put them all in one place), I'll test them out. If possible, just |>make one big diff from /usr/ports. Thanks! | | | Ok, I've got the patch after retesting with two extra patches approach. | Administrative questions: | Would you rather have this as a followup to ports/68747 or a separate PR | superceding 68747? Separate PR. | Should revisions of mozilla and firefox be bumped? Only is the ABI has changed (and it sounds like it hasn't). If Mozilla and Firefox will continue to operate just fine with the new freetype2, then PORTREVISIONs don't need to be bumped. | Oh and in case you don't like names of patches do tell :) - namely this adds | extra-patch2-nsSVGLibartGlyphMetricsFT.cpp | and | patch-bugzilla149334 | (it is attachment number of bugzilla entry #234035). No, the names sound fine, and tell us that these patches can go away when the bug is integrated. Joe | | | Dejan | - -- PGP Key : http://www.marcuscom.com/pgp.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (Darwin) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFCJ6Eyb2iPiv4Uz4cRAn6YAJsEWSaTNWyovoDoGrlkUBIaQo/YigCeNQXI zt/2ozgZ0+HMJCwFCLjoCJs= =Y5/N -----END PGP SIGNATURE-----