From owner-freebsd-hackers Sun Dec 15 13:21: 4 2002 Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C340C37B401 for ; Sun, 15 Dec 2002 13:21:02 -0800 (PST) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9E43243ED4 for ; Sun, 15 Dec 2002 13:21:00 -0800 (PST) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.6/8.12.6) with ESMTP id gBFLKpJe081556; Sun, 15 Dec 2002 22:20:52 +0100 (CET) (envelope-from phk@critter.freebsd.dk) To: Matthew Dillon Cc: Nate Lawson , freebsd-hackers@FreeBSD.ORG Subject: Re: setattr() syscall as proposed by phk From: phk@FreeBSD.ORG In-Reply-To: Your message of "Sun, 15 Dec 2002 13:11:05 PST." <200212152111.gBFLB5WI093761@apollo.backplane.com> Date: Sun, 15 Dec 2002 22:20:51 +0100 Message-ID: <81555.1039987251@critter.freebsd.dk> Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <200212152111.gBFLB5WI093761@apollo.backplane.com>, Matthew Dillon w rites: > setattr() and friends do not exist anywhere outside of this proposal. > I don't particularly like the idea of replacing existing functionality > with a new non-standard system call. The speed issue alone is not enough > to justify the change, nor is Kirk's new creation time field (besides > I thought that field was not supposed to be changeable?). > > -- > > In regards to the implementation itself, I really don't like the idea > of passing a stat structure as an argument. If we are going to have > a 'general' setattr() system call it should be extensible. That is, > something like this: > > struct fsattr { > int token; > union { > char pad[32]; > struct timeval tv; > time_t t; > etc.... > } fsu; > } I don't really like the idea of inventing new oddball structures when we have perfectly good ones already. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message