From owner-freebsd-current Fri Sep 29 8:48: 1 2000 Delivered-To: freebsd-current@freebsd.org Received: from shidahara1.planet.sci.kobe-u.ac.jp (shidahara1.planet.sci.kobe-u.ac.jp [133.30.50.200]) by hub.freebsd.org (Postfix) with ESMTP id ABE7837B422; Fri, 29 Sep 2000 08:47:58 -0700 (PDT) Received: from libr.scitec.kobe-u.ac.jp (skai0829.ppp.infoweb.ne.jp [202.248.14.237]) by shidahara1.planet.sci.kobe-u.ac.jp (8.9.3/8.9.3) with ESMTP id AAA39537; Sat, 30 Sep 2000 00:45:55 +0900 (JST) (envelope-from takawata@shidahara1.planet.sci.kobe-u.ac.jp) Received: from shidahara1.planet.kobe-u.ac.jp (localhost [127.0.0.1]) by libr.scitec.kobe-u.ac.jp (8.9.1/3.5Wpl7) with ESMTP id AAA20648; Sat, 30 Sep 2000 00:38:35 +0900 (JST) From: takawata@shidahara1.planet.sci.kobe-u.ac.jp Message-Id: <200009291538.AAA20648@libr.scitec.kobe-u.ac.jp> To: Mitsuru IWASAKI , msmith@freebsd.org Cc: acpi-jp@jp.freebsd.org, current@freebsd.org Subject: Re: ACPI megapatch In-reply-to: Your message of "Sat, 30 Sep 2000 00:04:50 JST." <20000930000450D.iwasaki@jp.FreeBSD.org> Date: Sat, 30 Sep 2000 00:38:34 +0900 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In message <20000930000450D.iwasaki@jp.FreeBSD.org>, Mitsuru IWASAKI wrote: >> In summary, my suggestions are >> - i386/i386/acpi_machdep.c >> acpi_find_rsdp() and acpi_mapmem() >> - dev/acpi/acpi.c >> acpi_identify() and acpi_find_facp() > >Here is a patch for your megapatch at >http://people.FreeBSD.org/~iwasaki/acpi/patch-for-megapatch.diff >I'll be happy if you accept and commit this :-) > I think it is better bus attachment code is in MD part than in MI part. And MD bus attachment code calls MI bus attachment code. For example,Current acpi_probe code rename to acpi_probesubr and call it from acpi_probe in acpi_machdep.c . And probe method and identify method should not be confused. Memory area check etc.... can be in MD acpi probe code. Takanori Watanabe Public Key Key fingerprint = 2C 51 E2 78 2C E1 C5 2D 0F F1 20 A3 11 3A 62 2A To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message