From owner-p4-projects@FreeBSD.ORG Wed Aug 27 14:20:47 2003 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 88C3F16A4C1; Wed, 27 Aug 2003 14:20:47 -0700 (PDT) Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 459CF16A4BF for ; Wed, 27 Aug 2003 14:20:47 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CC5B343FAF for ; Wed, 27 Aug 2003 14:20:46 -0700 (PDT) (envelope-from sam@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h7RLKk0U024067 for ; Wed, 27 Aug 2003 14:20:46 -0700 (PDT) (envelope-from sam@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h7RLKk1G024064 for perforce@freebsd.org; Wed, 27 Aug 2003 14:20:46 -0700 (PDT) Date: Wed, 27 Aug 2003 14:20:46 -0700 (PDT) Message-Id: <200308272120.h7RLKk1G024064@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to sam@freebsd.org using -f From: Sam Leffler To: Perforce Change Reviews Subject: PERFORCE change 37038 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Aug 2003 21:20:48 -0000 http://perforce.freebsd.org/chv.cgi?CH=37038 Change 37038 by sam@sam_ebb on 2003/08/27 14:20:07 remove explicit unlocks before destroying the mutex; whatever caused the panic's appears to be fixed Affected files ... .. //depot/projects/netperf/sys/net/route.c#6 edit Differences ... ==== //depot/projects/netperf/sys/net/route.c#6 (text+ko) ==== @@ -275,7 +275,6 @@ /* * and the rtentry itself of course */ - RT_UNLOCK(rt); RT_LOCK_DESTROY(rt); Free(rt); return; @@ -649,7 +648,6 @@ */ RT_LOCK(rt); if ((error = rt_setgate(rt, dst, gateway)) != 0) { - RT_UNLOCK(rt); RT_LOCK_DESTROY(rt); Free(rt); senderr(error); @@ -713,7 +711,6 @@ if (rt->rt_ifa) IFAFREE(rt->rt_ifa); Free(rt_key(rt)); - RT_UNLOCK(rt); RT_LOCK_DESTROY(rt); Free(rt); senderr(EEXIST);