From owner-freebsd-bugs Mon Aug 5 14:36:59 1996 Return-Path: owner-bugs Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id OAA22610 for bugs-outgoing; Mon, 5 Aug 1996 14:36:59 -0700 (PDT) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id OAA22592 for ; Mon, 5 Aug 1996 14:36:52 -0700 (PDT) Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.12/8.6.9) id HAA23802; Tue, 6 Aug 1996 07:33:52 +1000 Date: Tue, 6 Aug 1996 07:33:52 +1000 From: Bruce Evans Message-Id: <199608052133.HAA23802@godzilla.zeta.org.au> To: freebsd-bugs@freefall.freebsd.org, wollman@lcs.mit.edu Subject: Re: bin/1459: error messages lacking in /usr/bin/fetch Sender: owner-bugs@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > > + err (1, "Could not open output file %s\n", outputfile); CHanges should be formatted in the standard style (no space after function names before '('). > Error messages should not be capitalized. > > Putting a newline on the end of a message makes it look stupid: > > fetch: Could not open output file foo > : Permission denied Committers should test submitted changes. Bruce