From owner-freebsd-ports@FreeBSD.ORG Tue Jan 18 11:43:52 2005 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4C95B16A4CE for ; Tue, 18 Jan 2005 11:43:52 +0000 (GMT) Received: from postfix4-2.free.fr (postfix4-2.free.fr [213.228.0.176]) by mx1.FreeBSD.org (Postfix) with ESMTP id E229743D46 for ; Tue, 18 Jan 2005 11:43:51 +0000 (GMT) (envelope-from tataz@tataz.chchile.org) Received: from tatooine.tataz.chchile.org (vol75-8-82-233-239-98.fbx.proxad.net [82.233.239.98]) by postfix4-2.free.fr (Postfix) with ESMTP id 226DE2AA8C2; Tue, 18 Jan 2005 12:43:50 +0100 (CET) Received: by tatooine.tataz.chchile.org (Postfix, from userid 1000) id A1FD4407C; Tue, 18 Jan 2005 12:43:44 +0100 (CET) Date: Tue, 18 Jan 2005 12:43:44 +0100 From: Jeremie Le Hen To: Florent Thoumie Message-ID: <20050118114344.GR36629@obiwan.tataz.chchile.org> References: <20050118085557.GP36629@obiwan.tataz.chchile.org> <41ECD481.4020308@xbsd.org> <20050118103850.GQ36629@obiwan.tataz.chchile.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050118103850.GQ36629@obiwan.tataz.chchile.org> User-Agent: Mutt/1.5.6i cc: riggs@rrr.de cc: Jeremie Le Hen cc: freebsd-ports@freebsd.org Subject: Re: WITHOUT_X11 knob for mplayer X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jan 2005 11:43:52 -0000 > Ok, I'm going to update my patch today. Thanks for the tip. Well I updated the patch and then tried to rebuild mplayer on my no-X11 computer, unfortunately xorg-libraries has been built. I had a look in the porter's handbook. Here are the drawbacks I found about using USE_IMAKE knob: %%% Define USE_XLIB=yes if your port requires the X Window System to be installed (it is implied by USE_IMAKE). USE_IMAKE The port uses imake. Implies USE_X_PREFIX. %%% Obviously, this would make my patch completely useless :-). Whereas it can be interpreted as an inconsistency in the mplayer build system (usage of imake(1) even if not linked with X11 libs), my opinion is that this is a ports system weakness for this particular situation. Nevertheless I'm convinced there are good reasons to have the USE_IMAKE knob implying the USE_XLIB one. I would like to circomvent the use of USE_IMAKE here. Florent stated that the imake version depends on X_WINDOWS_SYSTEM but my BUILD_DEPENDS is only used when the WITHOUT_X11 knob is on. Thus I think we could use an arbitrary version of imake (say imake-6). This won't be very fair for those still running XFree86 as X_WINDOWS_SYSTEM and building mplayer WITHOUT_X11, but there are obviously a very few. Do you all agree with me ? (Thus my patch will stay as-is, unless there is a good solution to solve this problem.) Regards, -- Jeremie Le Hen jeremie@le-hen.org