Date: Thu, 23 Apr 2009 21:09:47 +0000 (UTC) From: Konstantin Belousov <kib@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/sys/vm vm_object.c Message-ID: <200904232109.n3NL9sCk073193@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
kib 2009-04-23 21:09:47 UTC
FreeBSD src repository
Modified files:
sys/vm vm_object.c
Log:
SVN rev 191439 on 2009-04-23 21:09:47Z by kib
Do not call vm_page_lookup() from the ddb routine, namely from "show
vmopag" implementation. The vm_page_lookup() code modifies splay tree
of the object pages, and asserts that object lock is taken. First issue
could cause kernel data corruption, and second one instantly panics the
INVARIANTS-enabled kernel.
Take the advantage of the fact that object->memq is ordered by page index,
and iterate over memq to calculate the runs.
While there, make the code slightly more style-compliant by moving
variables declarations to the right place.
Discussed with: jhb, alc
Reviewed by: alc
MFC after: 2 weeks
Revision Changes Path
1.402 +13 -19 src/sys/vm/vm_object.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200904232109.n3NL9sCk073193>