From owner-freebsd-acpi@FreeBSD.ORG Mon Nov 8 22:06:32 2004 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5123816A4CE for ; Mon, 8 Nov 2004 22:06:32 +0000 (GMT) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id E003843D4C for ; Mon, 8 Nov 2004 22:06:31 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.0.34] (adsl-67-119-74-222.dsl.sntc01.pacbell.net [67.119.74.222]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id iA8M6RFp013399 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 8 Nov 2004 14:06:28 -0800 Message-ID: <418FEC21.2020603@root.org> Date: Mon, 08 Nov 2004 13:58:57 -0800 From: Nate Lawson User-Agent: Mozilla Thunderbird 0.9 (Windows/20041103) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Anish Mistry References: <200408021725.02891.mistry.7@osu.edu> <200408021729.31984.mistry.7@osu.edu> <411161C7.3040603@root.org> <200411081654.48042.mistry.7@osu.edu> In-Reply-To: <200411081654.48042.mistry.7@osu.edu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit cc: freebsd-acpi@freebsd.org Subject: Re: FJEX Fujitsu Function Buttons X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Nov 2004 22:06:32 -0000 Anish Mistry wrote: > On Wednesday 04 August 2004 06:23 pm, Nate Lawson wrote: > >>Anish Mistry wrote: >> >>>On Monday 02 August 2004 05:24 pm, Anish Mistry wrote: >>> >>>>I've cleaned up the acpi_fuji module. Please comment on what needs to >>>>be changed for it to be committed. Thanks. >>>> >>>>http://am-productions.biz/docs/acpi_fjex.tgz >>> >>>Wow, I'm a moron. Correct link: >>>http://am-productions.biz/docs/acpi_fuji.tgz >> >>Thanks for the update. We'll definitely review it, make comments, etc. >> However, no new drivers should be imported before 5.3-RELEASE. We >>need to spend time cleaning up existing drivers and bugfixing. > > Now that 5.3 is out the door what do I need to do to get this committed? Thanks for pinging me. I'd like to see it match style(9) (i.e. 8 space tabs.) All new code in acpi has done this. Also, it could use locking (serialization would be fine since this code isn't in any fast path). Also, I assume you have a script for driving it? -- Nate