From owner-freebsd-hackers Wed Feb 28 20:19:59 2001 Delivered-To: freebsd-hackers@freebsd.org Received: from bazooka.unixfreak.org (bazooka.unixfreak.org [63.198.170.138]) by hub.freebsd.org (Postfix) with ESMTP id 4B8BF37B719 for ; Wed, 28 Feb 2001 20:19:56 -0800 (PST) (envelope-from dima@unixfreak.org) Received: from hornet.unixfreak.org (hornet [63.198.170.140]) by bazooka.unixfreak.org (Postfix) with ESMTP id 224DD3E09; Wed, 28 Feb 2001 20:19:56 -0800 (PST) To: Brian Somers Cc: hackers@freebsd.org Subject: Re: Inheriting the nodump flag In-Reply-To: Message from Brian Somers of "Thu, 01 Mar 2001 01:06:19 GMT." <200103010106.f2116JS54201@hak.lan.Awfulhak.org> Date: Wed, 28 Feb 2001 20:19:55 -0800 From: Dima Dorfman Message-Id: <20010301041956.224DD3E09@bazooka.unixfreak.org> Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > > Attached below is a port of NetBSD's patch to FreeBSD's dump(8). > > dump's tree walker is a little weird, so the patch is a little more > > complicated than calling fts_set with FTS_SKIP. For the technical > > details of what it does, see: > > http://lists.openresources.com/NetBSD/tech-kern/msg00453.html. > [.....] > > Comments? > > Just that I noticed a typo in a comment where ``inherited'' is misspelt > ``herited'' going via your URL.... but it's fixed in the attached > patch :-) It's probably worth updating the web page. That page is the archive of the tech-kern@netbsd.org mailing list, and as such can't be changed (much less by me). I provided it because it offers a very good technical explanation of the patch, which I didn't want to repeat. I took the patch there almost verbatim, except for, obviously, the exact placement of the code, and the comments; I didn't take the latter because the person who wrote it isn't a natural English speaker (as far as I can tell, anyway), and as such didn't write such great comments ("such great" being a reference to the English grammar and spelling, not their technical accuracy). > > I'd certainly like to see this committed - I'm sick of backing up > release directories, cvs repositories and /usr/obj :-) Yes, this was my motivation for porting this, too. :-) Thanks Dima Dorfman dima@unixfreak.org P.S. I just sent this patch to -audit per request of rwatson. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message