From owner-freebsd-hackers@FreeBSD.ORG Thu Aug 3 14:35:06 2006 Return-Path: X-Original-To: freebsd-hackers@freebsd.org Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C134016A4E9 for ; Thu, 3 Aug 2006 14:35:06 +0000 (UTC) (envelope-from joao.barros@gmail.com) Received: from nz-out-0102.google.com (nz-out-0102.google.com [64.233.162.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7141C43D53 for ; Thu, 3 Aug 2006 14:35:05 +0000 (GMT) (envelope-from joao.barros@gmail.com) Received: by nz-out-0102.google.com with SMTP id 13so426727nzn for ; Thu, 03 Aug 2006 07:35:04 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:mime-version:content-type; b=CtxRVwAqkXT6ENe9QG9lyVNS7HSfvXOqLMSwE3/CasMnaqlEcYfvXA32YixykcBaewQ1snHzSUrXv66eAqS5ElE1SiKRE2HQtqAVss6v2lyv0XGuh9MgN7N4Vv/npRz93GlDmnZ9n5bTcS49hyilnPA0oF7NSIC5+I9Qr6pmqow= Received: by 10.35.40.10 with SMTP id s10mr3437210pyj; Thu, 03 Aug 2006 07:35:04 -0700 (PDT) Received: by 10.35.112.18 with HTTP; Thu, 3 Aug 2006 07:35:04 -0700 (PDT) Message-ID: <70e8236f0608030735m519d880fgebeca7108b859244@mail.gmail.com> Date: Thu, 3 Aug 2006 15:35:04 +0100 From: "Joao Barros" To: freebsd-hackers@freebsd.org MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_148041_22325824.1154615704773" Cc: Gleb Smirnoff Subject: [PATCH] add header "pppoe:" in ng_pppoe.c printfs X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2006 14:35:06 -0000 ------=_Part_148041_22325824.1154615704773 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline Hi, I recently switched ISPs which in turn led me from a cablemodem to an ADSL modem. After setting PPPoE up I started noticing this messages in the daily run outputs that that nice guy Charlie root sends me at 3am: Aug 3 08:24:54 ultra5 kernel: session in wrong state I was a bit suspicious of anything PPPoE related and a little search confirmed that, pointing directly at ng_pppoe.c Being this a cryptic message to say the least and to probably save someone some time when presented with this message I attach a patch that adds the header "pppoe:" in every printf that didn't have it, making it consistent with the rest of the file. I also noticed this message appears right before the ISP closes the connection due to time limit. I'm CCing those I see were the last ones to commit to this file and will file a PR if asked to. -- Joao Barros ------=_Part_148041_22325824.1154615704773 Content-Type: application/octet-stream; name=ng_pppoe.c.patch Content-Transfer-Encoding: base64 X-Attachment-Id: f_eqf89nw3 Content-Disposition: attachment; filename="ng_pppoe.c.patch" LS0tIG5nX3BwcG9lLmMub3JpZ2luYWwJVGh1IEF1ZyAwMyAxNTowOTo1MSAyMDA2CisrKyBuZ19w cHBvZS5jCVRodSBBdWcgMDMgMTU6MTY6MTUgMjAwNgpAQCAtMTEwOCArMTEwOCBAQAotCQkJCXBy aW50ZigiY291bGRuJ3QgbV9wdWxsdXBcbiIpOworCQkJCXByaW50ZigicHBwb2U6IGNvdWxkbid0 IG1fcHVsbHVwXG4iKTsKQEAgLTExMjcgKzExMjcgQEAKLQkJCQkJCXByaW50ZigiY291bGRuJ3Qg bV9wdWxsdXBcbiIpOworCQkJCQkJcHJpbnRmKCJwcHBvZTogY291bGRuJ3QgbV9wdWxsdXBcbiIp OwpAQCAtMTE1MCArMTE1MCBAQAotCQkJCQlwcmludGYoInBhY2tldCBmcmFnbWVudGVkXG4iKTsK KwkJCQkJcHJpbnRmKCJwcHBvZTogcGFja2V0IGZyYWdtZW50ZWRcbiIpOwpAQCAtMTIwNyArMTIw NyBAQAotCQkJCQlwcmludGYoIm5vIGhvc3QgdW5pcXVlIGZpZWxkXG4iKTsKKwkJCQkJcHJpbnRm KCJwcHBvZTogbm8gaG9zdCB1bmlxdWUgZmllbGRcbiIpOwpAQCAtMTIxMyArMTIxMyBAQAotCQkJ CQlwcmludGYoIm5vIG1hdGNoaW5nIHNlc3Npb25cbiIpOworCQkJCQlwcmludGYoInBwcG9lOiBu byBtYXRjaGluZyBzZXNzaW9uXG4iKTsKQEAgLTEyMjMgKzEyMjMgQEAKLQkJCQkJcHJpbnRmKCJz ZXNzaW9uIGluIHdyb25nIHN0YXRlXG4iKTsKKwkJCQkJcHJpbnRmKCJwcHBvZTogc2Vzc2lvbiBp biB3cm9uZyBzdGF0ZVxuIik7Cg== ------=_Part_148041_22325824.1154615704773--