From owner-svn-src-head@freebsd.org Sun Jul 8 00:59:56 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7556610441CD for ; Sun, 8 Jul 2018 00:59:56 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x22c.google.com (mail-it0-x22c.google.com [IPv6:2607:f8b0:4001:c0b::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0611476472 for ; Sun, 8 Jul 2018 00:59:56 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x22c.google.com with SMTP id l16-v6so22076099ita.0 for ; Sat, 07 Jul 2018 17:59:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+jaVBqcvDwEDhn7/CNN4rhS+QJoIK5dM9AbqzfdcvgQ=; b=VVWTYU83XrpHBp9Sbtlw8AQsKNXpBjH+nF9t+LROLuIRkVtuMH38paENwpeTFuqlNI ABWy/zorOqJpgVIF12gsAd0KlE13dUHZ8FXKEylrJmQDGtlT5gXaATp/FLPB9zYHq4i6 FQFsyTN5D5HNCDAPwDqFv9m98ZBvkg4WJNqaQgFZLuHsX4IvRzSQ90TPFtH+eXGLGapq LMB4kI9rCJqPpauWpOaZinhNCdNHzVPmhbiAiPsyn2+4LBXP2DDIb+dohkz2cJ3bb1e6 qJyGJ091RdqH8VoSaWowXWXFN8yksWZPj+meAiYJtyUaeHG9seWH1zzdm3TqCYWNCFbX wXng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+jaVBqcvDwEDhn7/CNN4rhS+QJoIK5dM9AbqzfdcvgQ=; b=G4ud+96Gqx1//2kjJnOx2ijYkZcYEu691V7KokYBZuGSk6tKUEQpHx8UYbw5MiibNx rKLRgVJJWDLeS+VhRDN9Hjo+oD0tprjXDk4V1c+ST6wPLqVcv1p2pxtQschg2Wy02LFn JPwSJCg6RASwceDvfAcAokrxJW1RKDLvHXrRNswHeZNeQgyryj4vCnmIjUaX4huqa7yV TbaJ1hKYS5sElCw2qsSeDC9ZKekeOf/IVktuGV5poeEoGcHe0RedirKxT1kROhkc1GmR T8BBOFDRuLb7+oSkIqP0Iy0vS2nHvm7ZUJAqAbSYmX8VJ6pmlXiWTWq6qRj9QUd/sigE aKrQ== X-Gm-Message-State: APt69E2pPUHCKRifAjYhHuJ3JwlHesQDs21J8xA4yMU4Ws+Md9tRtWIP mYUkp9V5Qa1eB46qV3HnDu2ENhbnHFnvvpnh6Mza5w== X-Google-Smtp-Source: AAOMgpcwPTsWNBQm/Z7KAaTFaDPGKq7KB0pKMCgIpy3q2i1tozyZn3TrHvLzdjgkVn+3Lv7Df+Ea2XsAk5xAXq1vt3o= X-Received: by 2002:a24:d0d7:: with SMTP id m206-v6mr11795691itg.1.1531011595355; Sat, 07 Jul 2018 17:59:55 -0700 (PDT) MIME-Version: 1.0 References: <201807071555.w67FtqrL004956@repo.freebsd.org> In-Reply-To: From: Warner Losh Date: Sat, 7 Jul 2018 18:59:42 -0600 Message-ID: Subject: Re: svn commit: r336068 - in head/sys: dev/amdsmb modules/amdsmb To: Andriy Gapon Cc: Warner Losh , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Jul 2018 00:59:56 -0000 On Sat, Jul 7, 2018, 6:51 PM Warner Losh wrote: > > > On Sat, Jul 7, 2018, 6:42 PM Andriy Gapon wrote: > >> On 07/07/2018 18:55, Warner Losh wrote: >> > Author: imp >> > Date: Sat Jul 7 15:55:52 2018 >> > New Revision: 336068 >> > URL: https://svnweb.freebsd.org/changeset/base/336068 >> > >> > Log: >> > Update AMDSMB to use PCI_MATCH >> >> Just curious if anyone still uses this driver for ancient hardware. >> maybe de-orbit time? >> > > No. All such discussions are on hold until I get the depreciation doc > done, due by the end of the month. Then it might be a good one, but there > is a lot in line in front of it... > > > Differential Review: https://reviews.freebsd.org/D16172 >> >> Just curious what's the point of referencing a review request that >> - had no reviewers >> - had no reviews >> - does not even have a description >> > > I shared it there for my GSoC student, and it wound up getting pushed as > part of a different commute train by mistake. > Stupid autocorrect. Commit train. An unrelated fix was committed to the branch I had for this by mistake (the ath one). I was in a hurry since I wanted to get on the road and didn't check before pushing. My bad. I didn't think it worth backing out... Warner > > > Added: >> > head/sys/modules/amdsmb/ >> > head/sys/modules/amdsmb/Makefile (contents, props changed) >> > Modified: >> > head/sys/dev/amdsmb/amdsmb.c >> > >> > Modified: head/sys/dev/amdsmb/amdsmb.c >> > >> ============================================================================== >> > --- head/sys/dev/amdsmb/amdsmb.c Sat Jul 7 15:25:16 2018 >> (r336067) >> > +++ head/sys/dev/amdsmb/amdsmb.c Sat Jul 7 15:55:52 2018 >> (r336068) >> > @@ -125,24 +125,22 @@ struct amdsmb_softc { >> > >> > static int amdsmb_detach(device_t dev); >> > >> > +struct pci_device_table amdsmb_devs[] = { >> > + { PCI_DEV(AMDSMB_VENDORID_AMD, AMDSMB_DEVICEID_AMD8111_SMB2), >> > + PCI_DESCR("AMD-8111 SMBus 2.0 Controller") } >> > +}; >> > + >> > static int >> > amdsmb_probe(device_t dev) >> > { >> > - u_int16_t vid; >> > - u_int16_t did; >> > + const struct pci_device_table *tbl; >> > >> > - vid = pci_get_vendor(dev); >> > - did = pci_get_device(dev); >> > + tbl = PCI_MATCH(dev, amdsmb_devs); >> > + if (tbl == NULL) >> > + return (ENXIO); >> > + device_set_desc(dev, tbl->descr); >> > >> > - if (vid == AMDSMB_VENDORID_AMD) { >> > - switch(did) { >> > - case AMDSMB_DEVICEID_AMD8111_SMB2: >> > - device_set_desc(dev, "AMD-8111 SMBus 2.0 >> Controller"); >> > - return (BUS_PROBE_DEFAULT); >> > - } >> > - } >> > - >> > - return (ENXIO); >> > + return (BUS_PROBE_DEFAULT); >> > } >> > >> > static int >> > >> > Added: head/sys/modules/amdsmb/Makefile >> > >> ============================================================================== >> > --- /dev/null 00:00:00 1970 (empty, because file is newly added) >> > +++ head/sys/modules/amdsmb/Makefile Sat Jul 7 15:55:52 2018 >> (r336068) >> > @@ -0,0 +1,8 @@ >> > +# $FreeBSD$ >> > + >> > +.PATH: ${SRCTOP}/sys/dev/amdsmb >> > + >> > +KMOD= amdsmb >> > +SRCS= amdsmb.c bus_if.h device_if.h pci_if.h smbus_if.h >> > + >> > +.include >> > >> >> >> -- >> Andriy Gapon >> >