From owner-svn-src-all@freebsd.org Fri Jan 15 01:11:41 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DFA58A82FB0; Fri, 15 Jan 2016 01:11:40 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pf0-x22d.google.com (mail-pf0-x22d.google.com [IPv6:2607:f8b0:400e:c00::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AF88D13B4; Fri, 15 Jan 2016 01:11:40 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-pf0-x22d.google.com with SMTP id q63so111830051pfb.1; Thu, 14 Jan 2016 17:11:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:reply-to:subject:references:to:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=j+qngKwuKHk8apv0OiNqG35hW1M8l7gxALL8FtC8cww=; b=lDA9XoeJm5ZfmY6fpKQgn7bafNWuqpY57DDXJYlAqWCOx+afitTOBr1GTDJwoYlYMX DHrnq1OMGiNfGOsLuE4WIxHwlTSjjs+IaxTEmVVdkMwXqwf14rKM08i64nf5VaQ3UeyI VGJjBctrB9QO8TeB24pmOgNkz592l3tN50VIIybO4huruTQCFNWIWKmR655fyBv4envC EbcIGu8ueKxMiH7CcLNfaaIVjXjJj/JkRtdbwtQL8M+lfD6W9HTlCwVChU+RtYYPHhpF nhzgXC/q1JD/c3LnXagW922vaWfSi4mZtH6CuvcFB11TxGRR/Pp0qx8PcIwvcxBgCv8b OgmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:reply-to:subject:references:to:from :message-id:date:user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=j+qngKwuKHk8apv0OiNqG35hW1M8l7gxALL8FtC8cww=; b=D3UU88y4/MWHB3AXdNOhyPeb1Lqp6b/JvcqgEK3NI6M40HniZXVXVnxL0bzSGoJ0nK 43NjsbD/Ra3oZXLaA81KseRWvv05AnvWbGl7PdUSK7VmYSHoEP2qQmtJEQUX1Z5dHKO4 14rFs7aw6Y6DVyK7iL0cczkEP0FxCJPsINN8EfL1KXZyCZJDogrkXDbSMA1W0fk3fC6+ +ZSWBJlhgnm9+1C5CpuXYvEb+MUNvrUIkOo0S97lXWitGWiCLAV6cR+CFTAsNeHGXB4G 5YrAXVCfb7CzXCI9TLAE/zIt+Lywl0ftIlMTfpzYPP1JWHy28hjrArotbjVan0ES6RM/ ZiAw== X-Gm-Message-State: ALoCoQlGeKliw2lL3KZAHY2+T9vJXK6EUo2cx68ux3+FjPYr027YNwpaPEuPq2bGb2h9j0r+S0IArQCrEQVHc6XgMvKX/eXwhw== X-Received: by 10.98.64.27 with SMTP id n27mr10850804pfa.58.1452820300185; Thu, 14 Jan 2016 17:11:40 -0800 (PST) Received: from ?IPv6:2001:44b8:31ae:7b01:54ef:eecf:d818:dea? (2001-44b8-31ae-7b01-54ef-eecf-d818-0dea.static.ipv6.internode.on.net. [2001:44b8:31ae:7b01:54ef:eecf:d818:dea]) by smtp.gmail.com with ESMTPSA id 63sm11826528pfo.67.2016.01.14.17.11.37 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 14 Jan 2016 17:11:39 -0800 (PST) Sender: Kubilay Kocak Reply-To: koobs@FreeBSD.org Subject: Re: svn commit: r293854 - head/sys/dev/e1000 References: <201601132147.u0DLlR38017711@repo.freebsd.org> To: Marius Strobl , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Kubilay Kocak Message-ID: <5698473F.8030203@FreeBSD.org> Date: Fri, 15 Jan 2016 12:11:27 +1100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:43.0) Gecko/20100101 Thunderbird/43.0 MIME-Version: 1.0 In-Reply-To: <201601132147.u0DLlR38017711@repo.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jan 2016 01:11:41 -0000 On 14/01/2016 8:47 AM, Marius Strobl wrote: > Author: marius > Date: Wed Jan 13 21:47:27 2016 > New Revision: 293854 > URL: https://svnweb.freebsd.org/changeset/base/293854 > > Log: > Given that em(4), lem(4) and igb(4) hardware doesn't require the > alignment guarantees provided by m_defrag(9), use m_collapse(9) > instead for performance reasons. > While at it, sanitize the statistics softc members, i. e. retire > unused ones and add SYSCTL nodes missing for actually used ones. > > Differential Revision: https://reviews.freebsd.org/D4717 > > Modified: > head/sys/dev/e1000/if_em.c > head/sys/dev/e1000/if_em.h > head/sys/dev/e1000/if_igb.c > head/sys/dev/e1000/if_igb.h > head/sys/dev/e1000/if_lem.c > head/sys/dev/e1000/if_lem.h What kind of performance / overhead delta can be expected for this change? Is this worth MFC and/or Relnotes ?