From owner-cvs-all@FreeBSD.ORG Mon Dec 31 23:48:06 2007 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BE28C16A418; Mon, 31 Dec 2007 23:48:06 +0000 (UTC) (envelope-from julian@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id ADA6613C448; Mon, 31 Dec 2007 23:48:06 +0000 (UTC) (envelope-from julian@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id lBVNm60Z031550; Mon, 31 Dec 2007 23:48:06 GMT (envelope-from julian@repoman.freebsd.org) Received: (from julian@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id lBVNm66P031549; Mon, 31 Dec 2007 23:48:06 GMT (envelope-from julian) Message-Id: <200712312348.lBVNm66P031549@repoman.freebsd.org> From: Julian Elischer Date: Mon, 31 Dec 2007 23:48:06 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/cxgb cxgb_l2t.c src/sys/netinet if_ether.c if_ether.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Dec 2007 23:48:06 -0000 julian 2007-12-31 23:48:06 UTC FreeBSD src repository Modified files: sys/dev/cxgb cxgb_l2t.c sys/netinet if_ether.c if_ether.h Log: Don't duplicate the whole of arpresolve to arpresolve 2 for the sake of two compares against 0. The negative effect of cache flushing is probably more than the gain by not doing the two compares (the value is almost certainly in register or at worst, cache). Note that the uses of m_freem() are in error cases and m_freem() handles NULL anyhow. So fast-path really isn't changed much at all. Revision Changes Path 1.6 +10 -6 src/sys/dev/cxgb/cxgb_l2t.c 1.170 +19 -120 src/sys/netinet/if_ether.c 1.34 +0 -2 src/sys/netinet/if_ether.h