From nobody Mon Feb 9 16:28:16 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f8qr05dVlz6RgJ8 for ; Mon, 09 Feb 2026 16:28:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f8qr03nkDz3Njr for ; Mon, 09 Feb 2026 16:28:16 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770654496; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=4lPElbY0ehkcfG9UPqrYG9mgmDJTuZdcb7uhqDBuxPg=; b=C45OKkqV6CFHgjdDHC6zoRPFFIabapSi3/0MhwUH3KH1CULEResK85jK5r6/BrLXgcmFni F4n0yk+GZGgl19qUS24biXN7mAkPLj42N411Bg2+AFeC4T8iBao12pMkmDYQBCr7fqSoR6 BXYUv6TiVj1pd645+9BpvqQ7g42ofgEcu0gLES790y3jfFs/o3TMXlPcKiEgxeH8omJdjm D46p9SQbNEBkHOnXTZBr6yKYwr9Niwno67ZltuOGrxuaPVEY2daDCziWQbfl0klvZq4Z0l R3bMRUcgtWpEXw5AyUWKUeWW6r+z123q0jXKwK482pGsjCtnWNqIF/00oK1DHg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770654496; a=rsa-sha256; cv=none; b=hxOeC1PFoitDzENswq9upqgoy1BwCLJ3OU4NbeR4iROL1/x+v1+WfLiyAM/r7WQ0PYAz+v 9WAdHs/xWUHHFQng6tHJstVBhJhbbYfMezteIFuo7o1/BFGlStj+d/0xeLm/gHadadQxFg mNI41MuMQ90D8je8Qr4/QoGV9gsIDEIyxre2LlE4y5U9thcysfD/7dP8Ksr1Y4hr9ovES8 bizII9qnupDTOWDz88sMn5ZHjr7steHxL/6uanBu0+qCyxGLWHPBH76AcnYazEubHYxGwI CUhP3hGpf7aQjsTyQeFDUXRyoquIx3jy8MnCxXMNhSKoKFhGo5X8DBlq6KUAOw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770654496; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=4lPElbY0ehkcfG9UPqrYG9mgmDJTuZdcb7uhqDBuxPg=; b=nnaVfD7XE49BVocSUUOQt6gZx/odi+UWR/cjsE09C/L+DmlvICE6RVohLrpfmCDU8qQHEZ 6I67CDWwTPyGRG7MOoiBqyNJNreeavHkdMP3JSxAeLlYRyUwaKWlE/zp1xPicECNp9IpQh 9lcv5PVFXouqnHnwa1LBSuDQKxevafKdEO0WpNZcNyp2H1/Ap37g12gxP9sPzPKGm3ndUU 41dF0oWDaFk+OjkG/9XY0beTvK6s4qHPxsg425iuyt2FpLdYYQvLtQFdfbYy3xg5OXKfuJ chCr9snb/jeR0/4sQnQmuotNOzS8tHYqVp2S9qZ7Mt5s1Ne8aOYuegaO/H9l9g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f8qr02hdszfsD for ; Mon, 09 Feb 2026 16:28:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1d298 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 09 Feb 2026 16:28:16 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: 3f18463745c9 - main - sdhci_fdt_rockchip: Don't return 0 from probe routine List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 3f18463745c9c75e1fdcfacc710799838ef5c9d9 Auto-Submitted: auto-generated Date: Mon, 09 Feb 2026 16:28:16 +0000 Message-Id: <698a0b20.1d298.10681036@gitrepo.freebsd.org> The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=3f18463745c9c75e1fdcfacc710799838ef5c9d9 commit 3f18463745c9c75e1fdcfacc710799838ef5c9d9 Author: John Baldwin AuthorDate: 2026-02-09 16:27:23 +0000 Commit: John Baldwin CommitDate: 2026-02-09 16:27:23 +0000 sdhci_fdt_rockchip: Don't return 0 from probe routine The only write to the softc is a no-op (softcs are initialized to all zeroes), so remove that and just use BUS_PROBE_DEFAULT. Reviewed by: bnovkov Differential Revision: https://reviews.freebsd.org/D55159 --- sys/dev/sdhci/sdhci_fdt_rockchip.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/sys/dev/sdhci/sdhci_fdt_rockchip.c b/sys/dev/sdhci/sdhci_fdt_rockchip.c index 79d299f75fb4..2d0ade8055e7 100644 --- a/sys/dev/sdhci/sdhci_fdt_rockchip.c +++ b/sys/dev/sdhci/sdhci_fdt_rockchip.c @@ -113,9 +113,6 @@ static struct ofw_compat_data compat_data[] = { static int sdhci_fdt_rockchip_probe(device_t dev) { - struct sdhci_fdt_softc *sc = device_get_softc(dev); - - sc->quirks = 0; if (!ofw_bus_status_okay(dev)) return (ENXIO); @@ -130,7 +127,7 @@ sdhci_fdt_rockchip_probe(device_t dev) return (ENXIO); } - return (0); + return (BUS_PROBE_DEFAULT); } static int