From owner-cvs-all Tue Oct 3 9:58:39 2000 Delivered-To: cvs-all@freebsd.org Received: from rover.village.org (rover.village.org [204.144.255.49]) by hub.freebsd.org (Postfix) with ESMTP id 2BD7637B502; Tue, 3 Oct 2000 09:58:34 -0700 (PDT) Received: from harmony.village.org (harmony.village.org [10.0.0.6]) by rover.village.org (8.11.0/8.11.0) with ESMTP id e93GwUM10196; Tue, 3 Oct 2000 10:58:31 -0600 (MDT) (envelope-from imp@harmony.village.org) Received: from harmony.village.org (localhost.village.org [127.0.0.1]) by harmony.village.org (8.9.3/8.8.3) with ESMTP id KAA27159; Tue, 3 Oct 2000 10:58:30 -0600 (MDT) Message-Id: <200010031658.KAA27159@harmony.village.org> To: Christopher Masto Subject: Re: cvs commit: src/usr.bin/finger finger.c Cc: Paul Richards , Kris Kennaway , Joseph Scott , Brian Somers , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, freebsd-security@FreeBSD.ORG In-reply-to: Your message of "Tue, 03 Oct 2000 12:40:08 EDT." <20001003124008.A4892@netmonger.net> References: <20001003124008.A4892@netmonger.net> <39D98B55.126DAFC4@originative.co.uk> <200010022227.PAA62603@freefall.freebsd.org> <39D92E08.E00CF2E4@owp.csus.edu> <20001002180303.A40584@freefall.freebsd.org> <39D98B55.126DAFC4@originative.co.uk> <200010031530.JAA26493@harmony.village.org> Date: Tue, 03 Oct 2000 10:58:30 -0600 From: Warner Losh Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In message <20001003124008.A4892@netmonger.net> Christopher Masto writes: : The problem with being too cautious is that stable becomes unusable : and people who shouldn't be running current start moving to it because : stable doesn't support their new laptop. That's a compelling reason. However, rushing it into stable to keep one or two people from running -current isn't in our best interests either. You'll notice that I say you need two people to check the code. If you can't find two people to check the code, then nobody cares enough for it to go into stable. Two people. I didn't say two committers, but two people who can review the code. If you can't meet that low threshold, then you shouldn't merge the new feature. Period. : I think it's important to push _some_ features into stable. Having to : wait several years for the next major "point-oh" release of FreeBSD : (which comes with "point-oh fear" holding it back) is not the best : way to do things. IMO. There's a place between these two extremes : of paranoia and wild abandon, and I think that's where the MFCs should : take place. I don't advocate paranoia. I advocate caution and good engineering practices before code can be allowed into MFC, especially new features. We used to be really good about this and as we've grown the cautious merge into -stable ethic has become diluted. It is time to tighten things down for a while again. The finger thing has shown that the current practices are too loose. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message