From owner-freebsd-ports@FreeBSD.ORG Wed Mar 11 13:37:01 2009 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 07F67106566B for ; Wed, 11 Mar 2009 13:37:01 +0000 (UTC) (envelope-from eitanadlerlist@gmail.com) Received: from mail-gx0-f176.google.com (mail-gx0-f176.google.com [209.85.217.176]) by mx1.freebsd.org (Postfix) with ESMTP id AFB688FC1B for ; Wed, 11 Mar 2009 13:37:00 +0000 (UTC) (envelope-from eitanadlerlist@gmail.com) Received: by gxk24 with SMTP id 24so16667gxk.19 for ; Wed, 11 Mar 2009 06:36:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :x-enigmail-version:openpgp:content-type:content-transfer-encoding; bh=e2j/fqBk1UxB3NsUjwBpUC8MI9wHboruXW7dsAgtOWU=; b=nEOsIkU6oYUfbLhhTO9jmI8d+vaw5T3VdvoGuTfu2vRStodmN3w7rU7w4yhEDtSJZz AwjKx8j8SYNTsaKjCnJnqqD/IbdB+S5PC8BsYM1qveP3esAsgawdIcUkb35LNowlo8cI 4HWyQUZXMFJmVnLGogYCvCu/rGrdhDwZAUX4o= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:openpgp:content-type :content-transfer-encoding; b=oz3bHMNId7ZjLBbLQGv8vBEZbnEP2bD7bxEGxuN76FKon1e/CTkuq6SntUwoDU5fng u6zbxqXVL2qaviTtrt/dqBUQad/4irIglk0I2eGmA1ERQWm4GU1Xu8LUvInXXhs+kiRr CmFB2Jzh3NNnVSXOpW8QDmp6awZYgXNpOVtFw= Received: by 10.142.173.8 with SMTP id v8mr3683894wfe.181.1236778619466; Wed, 11 Mar 2009 06:36:59 -0700 (PDT) Received: from aargh.lan (ool-182fcc8b.dyn.optonline.net [24.47.204.139]) by mx.google.com with ESMTPS id 30sm14392799wfc.24.2009.03.11.06.36.58 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 11 Mar 2009 06:36:58 -0700 (PDT) Message-ID: <49B7BE84.3050106@gmail.com> Date: Wed, 11 Mar 2009 09:37:08 -0400 From: Eitan Adler User-Agent: Mozilla (X11; U; FreeBSD i386; en-US; ) Gecko Thunderbird Mnenhy/0.7.6.666 MIME-Version: 1.0 To: avg@icyb.net.ua References: <49B6A827.50705@icyb.net.ua> In-Reply-To: <49B6A827.50705@icyb.net.ua> X-Enigmail-Version: 0.95.7 OpenPGP: id=E9C2CCD1; url=pgp.mit.edu Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: freebsd-ports@FreeBSD.ORG Subject: Re: request for a new port review [memtest86+] X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Mar 2009 13:37:01 -0000 Andriy Gapon wrote: > Guys, > > could you please review the below port for correctness, style and general approach > taken by me. http://isis.poly.edu/~eitan/files/patch-memtest86+-port.diff Apply this patch then install the port "portlint" and run portlint -CNA. Always use tabs - not spaces. -- Eitan Adler "Security is increased by designing for the way humans actually behave." -Jakob Nielsen