Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 8 Jun 2020 09:23:52 +0000 (UTC)
From:      Hans Petter Selasky <hselasky@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org
Subject:   svn commit: r361906 - stable/12/sys/dev/usb
Message-ID:  <202006080923.0589NqS7029458@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: hselasky
Date: Mon Jun  8 09:23:52 2020
New Revision: 361906
URL: https://svnweb.freebsd.org/changeset/base/361906

Log:
  MFC r361577:
  Don't allow USB device drivers to parent own interface.
  It will prevent proper USB device detach.
  
  Sponsored by:	Mellanox Technologies

Modified:
  stable/12/sys/dev/usb/usb_device.c
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/sys/dev/usb/usb_device.c
==============================================================================
--- stable/12/sys/dev/usb/usb_device.c	Mon Jun  8 08:52:02 2020	(r361905)
+++ stable/12/sys/dev/usb/usb_device.c	Mon Jun  8 09:23:52 2020	(r361906)
@@ -1402,7 +1402,7 @@ usbd_set_parent_iface(struct usb_device *udev, uint8_t
 {
 	struct usb_interface *iface;
 
-	if (udev == NULL) {
+	if (udev == NULL || iface_index == parent_index) {
 		/* nothing to do */
 		return;
 	}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202006080923.0589NqS7029458>