Date: Wed, 13 Dec 2000 18:09:45 -0500 From: Chris Faulhaber <jedgar@fxp.org> To: "Michael C . Wu" <keichii@peorth.iteration.net> Cc: freebsd-audit@freebsd.org Subject: Re: libintl audit. Message-ID: <20001213180945.A79894@peitho.fxp.org> In-Reply-To: <20001213163638.A17119@peorth.iteration.net>; from keichii@iteration.net on Wed, Dec 13, 2000 at 04:36:38PM -0600 References: <20001213163638.A17119@peorth.iteration.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Dec 13, 2000 at 04:36:38PM -0600, Michael C . Wu wrote: > Hello guys, > > Will someone audit the attached tarball for me? :) > So far: you should probably check the return values of strdup(3) calls. I will take a closer look at the code when I get a chance this evening :) -- Chris D. Faulhaber - jedgar@fxp.org - jedgar@FreeBSD.org -------------------------------------------------------- FreeBSD: The Power To Serve - http://www.FreeBSD.org --- gettext.c.orig Wed Dec 6 02:39:35 2000 +++ gettext.c Wed Dec 13 18:01:11 2000 @@ -405,6 +405,8 @@ v = NULL; if (v) { mohandle.mo.mo_charset = strdup(v + 8); + if (!mohandle.mo.mo_charset) + goto fail; v = strchr(mohandle.mo.mo_charset, '\n'); if (v) *v = '\0'; @@ -575,9 +577,13 @@ if (odomainname) free(odomainname); odomainname = strdup(domainname); + if (!odomainname) + goto fail; if (ocname) free(ocname); ocname = strdup(cname); + if (!ocname) + goto fail; strlcpy(olpath, lpath, sizeof(olpath)); To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20001213180945.A79894>