From owner-svn-src-all@freebsd.org Fri Oct 14 13:20:03 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DF2A4C10429; Fri, 14 Oct 2016 13:20:03 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citapm.icyb.net.ua (citapm.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 4504F64E; Fri, 14 Oct 2016 13:20:02 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citapm.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id QAA09074; Fri, 14 Oct 2016 16:20:00 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1bv2P2-000KrM-MC; Fri, 14 Oct 2016 16:20:00 +0300 Subject: Re: svn commit: r307317 - in head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs: . sys To: Alexander Motin , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org References: <201610141201.u9EC1X2O073182@repo.freebsd.org> <0e5b9464-e039-1c00-9805-6110f154f9f0@FreeBSD.org> <65265e09-a704-86c0-8e8a-ed423c941d40@FreeBSD.org> From: Andriy Gapon Message-ID: <030747b3-a83c-8b16-d9b1-3d5d3b7ae142@FreeBSD.org> Date: Fri, 14 Oct 2016 16:18:39 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <65265e09-a704-86c0-8e8a-ed423c941d40@FreeBSD.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Oct 2016 13:20:04 -0000 On 14/10/2016 15:22, Alexander Motin wrote: > On 14.10.2016 15:11, Andriy Gapon wrote: >> On 14/10/2016 15:01, Alexander Motin wrote: >>> Author: mav >>> Date: Fri Oct 14 12:01:33 2016 >>> New Revision: 307317 >>> URL: https://svnweb.freebsd.org/changeset/base/307317 >>> >>> Log: >>> MFV r307313: >>> 5120 zfs should allow large block/gzip/raidz boot pool (loader project) >>> >>> Reviewed by: George Wilson >>> Reviewed by: Yuri Pankov >>> Reviewed by: Andrew Stormont >>> Reviewed by: Matthew Ahrens >>> Approved by: Robert Mustacchi >>> Author: Toomas Soome >>> >>> openzfs/openzfs@c8811bd3e2427dddbac6c05a59cfe117d8fea370 >>> >>> FreeBSD still does not support booting from gzip-compressed datasets, >>> so keep one chunk of this commit out. >> >> Does FreeBSD boot code support large blocks? Just to be sure. > > According to r304321 commit message -- it does now. Okay. >> And maybe this is worth some additional notice because users sometimes forget to >> upgrade gptzfsboot / zfsboot. > > Where would you like to see it to be noticeable? That's a good question for which I do not have a good answer. Ideally 'zfs set recordsize=' would warn when setting a large block size on a boot filesystem and 'zpool set bootfs=' would warn when switching the boot filesystem to a filesystem that already has a large block size. But not sure if that's doable without kludges. -- Andriy Gapon