From owner-freebsd-threads@FreeBSD.ORG Sat Sep 16 20:59:10 2006 Return-Path: X-Original-To: freebsd-threads@FreeBSD.org Delivered-To: freebsd-threads@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9094E16A500; Sat, 16 Sep 2006 20:59:10 +0000 (UTC) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (gate.funkthat.com [69.17.45.168]) by mx1.FreeBSD.org (Postfix) with ESMTP id B05B843D55; Sat, 16 Sep 2006 20:59:09 +0000 (GMT) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (ivo8j3xnjq7wkrqz@localhost.funkthat.com [127.0.0.1]) by hydrogen.funkthat.com (8.13.6/8.13.3) with ESMTP id k8GKx9Bu065710; Sat, 16 Sep 2006 13:59:09 -0700 (PDT) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.13.6/8.13.3/Submit) id k8GKx9lg065709; Sat, 16 Sep 2006 13:59:09 -0700 (PDT) (envelope-from jmg) Date: Sat, 16 Sep 2006 13:59:08 -0700 From: John-Mark Gurney To: Anders Nordby Message-ID: <20060916205908.GG9421@funkthat.com> Mail-Followup-To: Anders Nordby , FreeBSD-gnats-submit@FreeBSD.org, freebsd-threads@FreeBSD.org, Thomas-Martin Seck , Suleiman Souhlal References: <20060911075431.D12758D9874@fupp.net> <200609110800.k8B80ie3041853@freefall.freebsd.org> <20060912195547.GA71462@totem.fix.no> <20060913185803.GA27955@totem.fix.no> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="oC1+HKm2/end4ao3" Content-Disposition: inline In-Reply-To: <20060913185803.GA27955@totem.fix.no> User-Agent: Mutt/1.4.2.1i X-Operating-System: FreeBSD 5.4-RELEASE-p6 i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html Cc: Suleiman Souhlal , FreeBSD-gnats-submit@FreeBSD.org, Thomas-Martin Seck , freebsd-threads@FreeBSD.org Subject: Re: threads/103127: Kernel panic while using thread features in Squid 2.6 X-BeenThere: freebsd-threads@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: John-Mark Gurney List-Id: Threading on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Sep 2006 20:59:10 -0000 --oC1+HKm2/end4ao3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Anders Nordby wrote this message on Wed, Sep 13, 2006 at 20:58 +0200: > After talking with Pawel, I tried the attached patch to get some kqueue > debug info. I just got it: > > Sep 13 20:18:56 cache3 kernel: NULL f_event in new kn > Sep 13 20:18:56 cache3 kernel: f_event == NULL > > Then Squid stops responding to new requests, and I can not even kill it > with kill -9: Please try the attached patch.. It appears that the badfo_kqfilter was returning sucess instead of error since it was introcuded many years ago... This many still cause other problems w/ squid, but will fix the panics... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not." --oC1+HKm2/end4ao3 Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="badfo_kqfilter.patch" Index: kern_descrip.c =================================================================== RCS file: /home/ncvs/src/sys/kern/kern_descrip.c,v retrieving revision 1.297 diff -u -r1.297 kern_descrip.c --- kern_descrip.c 21 Jul 2006 20:24:00 -0000 1.297 +++ kern_descrip.c 16 Sep 2006 20:58:40 -0000 @@ -2632,7 +2632,7 @@ badfo_kqfilter(struct file *fp, struct knote *kn) { - return (0); + return (EINVAL); } static int --oC1+HKm2/end4ao3--