From owner-freebsd-current@FreeBSD.ORG Wed Sep 3 13:12:47 2008 Return-Path: Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 57E6B106564A; Wed, 3 Sep 2008 13:12:47 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (tim.des.no [194.63.250.121]) by mx1.freebsd.org (Postfix) with ESMTP id 122428FC13; Wed, 3 Sep 2008 13:12:46 +0000 (UTC) (envelope-from des@des.no) Received: from ds4.des.no (des.no [84.49.246.2]) by smtp.des.no (Postfix) with ESMTP id 54ADA207E; Wed, 3 Sep 2008 15:12:45 +0200 (CEST) Received: by ds4.des.no (Postfix, from userid 1001) id 45C8B8447B; Wed, 3 Sep 2008 15:12:45 +0200 (CEST) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: "army.of.root\@googlemail.com" References: <48BB403C.5090103@googlemail.com> Date: Wed, 03 Sep 2008 15:12:45 +0200 In-Reply-To: <48BB403C.5090103@googlemail.com> (army's message of "Mon, 01 Sep 2008 03:07:08 +0200") Message-ID: <86d4jl9xv6.fsf@ds4.des.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: freebsd-current@FreeBSD.org, Rui Paulo Subject: Re: k8temp choose the higher temp of the two sensors on one core X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Sep 2008 13:12:47 -0000 "army.of.root@googlemail.com" writes: > I noticed that not the highest of the two temp values of one core is used: > > dev.cpu.0.temperature: 46 > dev.cpu.1.temperature: 46 <=3D=3D > dev.k8temp.0.%desc: AMD K8 Thermal Sensors > dev.k8temp.0.%driver: k8temp > dev.k8temp.0.%parent: hostb3 > dev.k8temp.0.sensor0.core0: 46 > dev.k8temp.0.sensor0.core1: 49 <=3D=3D > dev.k8temp.0.sensor1.core0: 46 > dev.k8temp.0.sensor1.core1: 46 > > I assume the dev.cpu.1.temperature sysctl comes from the k8temp > module, because it only shows up if it is loaded. That's not the only error: sysctlnode =3D SYSCTL_ADD_NODE(sysctlctx, SYSCTL_CHILDREN(device_get_sysctl_tree(dev)), OID_AUTO, "sensor= 1", CTLFLAG_RD, 0, "Sensor 1"); =20=20=20=20=20=20=20=20 SYSCTL_ADD_PROC(sysctlctx, SYSCTL_CHILDREN(sysctlnode), OID_AUTO, "core0", CTLTYPE_INT | CTLFLAG_RD, dev, SENSOR0_CORE0, k8temp_sysctl, "I", "Sensor 1 / Core 0 temperature"); =20=20=20=20=20=20=20=20 SYSCTL_ADD_PROC(sysctlctx, SYSCTL_CHILDREN(sysctlnode), OID_AUTO, "core1", CTLTYPE_INT | CTLFLAG_RD, dev, SENSOR0_CORE0, k8temp_sysctl, "I", "Sensor 1 / Core 1 temperature"); Another thing - wouldn't coreX.sensorY make more sense than sensorY.coreX? DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no