From owner-svn-ports-head@freebsd.org  Mon Oct 26 15:51:08 2015
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id EB43E838E;
 Mon, 26 Oct 2015 15:51:08 +0000 (UTC)
 (envelope-from bdrewery@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id D667E14BD;
 Mon, 26 Oct 2015 15:51:08 +0000 (UTC)
 (envelope-from bdrewery@FreeBSD.org)
Received: from mail.xzibition.com (localhost [IPv6:::1])
 by freefall.freebsd.org (Postfix) with ESMTP id CDF8E1F31;
 Mon, 26 Oct 2015 15:51:08 +0000 (UTC)
 (envelope-from bdrewery@FreeBSD.org)
Received: from mail.xzibition.com (localhost [172.31.3.2])
 by mail.xzibition.com (Postfix) with ESMTP id 75FD915656;
 Mon, 26 Oct 2015 15:51:08 +0000 (UTC)
X-Virus-Scanned: amavisd-new at mail.xzibition.com
Received: from mail.xzibition.com ([172.31.3.2])
 by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new,
 port 10026)
 with LMTP id sQl1gIK0-WBW; Mon, 26 Oct 2015 15:51:06 +0000 (UTC)
Subject: Re: svn commit: r400154 - in head/ports-mgmt/portlint: . src
DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com ADE781564E
To: Joe Marcus Clarke <marcus@freebsd.org>,
 Alexey Dokuchaev <danfe@FreeBSD.org>
References: <201510251727.t9PHRckC024802@repo.freebsd.org>
 <20151026084707.GA33313@FreeBSD.org> <562E3A17.2010103@freebsd.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
From: Bryan Drewery <bdrewery@FreeBSD.org>
Organization: FreeBSD
Message-ID: <562E4BE7.4090003@FreeBSD.org>
Date: Mon, 26 Oct 2015 08:51:03 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0)
 Gecko/20100101 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <562E3A17.2010103@freebsd.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Oct 2015 15:51:09 -0000

On 10/26/15 7:35 AM, Joe Marcus Clarke wrote:
> On 10/26/15 04:47, Alexey Dokuchaev wrote:
>> On Sun, Oct 25, 2015 at 05:27:38PM +0000, Joe Marcus Clarke wrote:
>>> New Revision: 400154
>>> URL: https://svnweb.freebsd.org/changeset/ports/400154
>>>
>>> Log:
>>>    Update to 2.16.7.
>>>
>>>    * Remove the check for USES being sorted.  Order is important. [2]
>>>    PR:        203908 [2]
>>
>> PR fails to provide any specifics though.  USES should be order-agnostic;
>> dependencies should be specified explicitly.  Sorted USES might actually
>> help to find those bugs (any are known?) and fix them quickly.
>>
>> Relying on a specific USES order is a bug.
>>
>> ./danfe
>>
> 
> This is why I left the code commented out instead of removing it
> outright.  This clearly needs more discussion.
> 
> Bryan, care to fill us in?
> 
> Joe
> 

Here's just 1 example:

~/svn/ports/Mk/Uses # grep ^MAKE_CMD= *
fmake.mk:MAKE_CMD=              ${FMAKE}
gmake.mk:MAKE_CMD=              gmake${_GMAKE_EXT}
ninja.mk:MAKE_CMD=      ninja
scons.mk:MAKE_CMD=              ${SCONS}
waf.mk:MAKE_CMD=        ${PYTHON_CMD} ${WAF_CMD}

The last one wins.

There are likely other cases too, sorting for the sake of sorting is not
safe.

-- 
Regards,
Bryan Drewery