From owner-svn-src-head@FreeBSD.ORG Tue Jan 5 05:52:48 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DB7DD106568B; Tue, 5 Jan 2010 05:52:48 +0000 (UTC) (envelope-from kabaev@gmail.com) Received: from mail-qy0-f176.google.com (mail-qy0-f176.google.com [209.85.221.176]) by mx1.freebsd.org (Postfix) with ESMTP id 4AF408FC12; Tue, 5 Jan 2010 05:52:48 +0000 (UTC) Received: by qyk6 with SMTP id 6so6727120qyk.3 for ; Mon, 04 Jan 2010 21:52:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:in-reply-to:references:x-mailer:mime-version :content-type; bh=5veqIyWsBJBPmAoQivUKz6LaJXcBM36hA2APJK09+rA=; b=eGD/qy0HzItXbOOJGbt1fTOq1FvxQ0Bb5/L/gb00AQ8GHhR9qeqmLorHXpb9Nve3h1 A3+VEKFuF5UU29Jmiotn2C5bj4ek2nu2yIqSlyWyW1d8WMn9Wj3BnMTQs574SysTtPBk LSg5OV0G2WXVHFNYYXzuL5dbVIXM4ap6pZBoE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer :mime-version:content-type; b=O3qXOeM4w+pRFXuENIcPApt4p+d7uVd7vWj4v/xnaUsm0cKxBg4RA53qfCEn6H7mfw CbOv1FYYzoZFeKNQM0jSIRPClj/ae5MqCdMHulVTYuiWXdTGEInLWJ2mDxHEln+q1cdl kxgbX8JSVRezuRtY8WhGt1H2z9vD9nw5fmz6M= Received: by 10.224.63.202 with SMTP id c10mr11790159qai.39.1262670762158; Mon, 04 Jan 2010 21:52:42 -0800 (PST) Received: from kan.dnsalias.net (c-24-91-218-112.hsd1.ma.comcast.net [24.91.218.112]) by mx.google.com with ESMTPS id 4sm50712932qwe.5.2010.01.04.21.52.39 (version=SSLv3 cipher=RC4-MD5); Mon, 04 Jan 2010 21:52:40 -0800 (PST) Date: Tue, 5 Jan 2010 00:50:42 -0500 From: Alexander Kabaev To: David Xu Message-ID: <20100105005042.7fd9db85@kan.dnsalias.net> In-Reply-To: <4B42D07A.5000803@freebsd.org> References: <201001050339.o053dV1j075171@svn.freebsd.org> <20100104233946.6d8bfa37@kan.dnsalias.net> <4B42D07A.5000803@freebsd.org> X-Mailer: Claws Mail 3.7.3 (GTK+ 2.18.5; amd64-portbld-freebsd9.0) Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/r1jJl/6LmJiltlx8/HPQCSW"; protocol="application/pgp-signature" Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r201547 - head/lib/libc/gen X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jan 2010 05:52:49 -0000 --Sig_/r1jJl/6LmJiltlx8/HPQCSW Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Tue, 05 Jan 2010 13:39:06 +0800 David Xu wrote: > Alexander Kabaev wrote: > > Hi, > >=20 > > some quick questions: > >=20 > > FB10_COMPAT_PRIVATE is not used anywhere, why did it get committed? > > That aside, use of SYM_DEFAULT is pretty much always wrong. > >=20 > Yes, this needs to be cleaned. >=20 > > Also, does libthr really need to export sem_ symbols in 1.2 > > namespace? I do not think so, but there might be reasons I am > > missing, could you shed some light here? > >=20 >=20 > If libthr.so does not have 1.2 semaphore, a program linked against=20 > libthr may use 1.0 version at linking time, doesn't this cause > trouble? anyway, I am not symbol versioning expert, welcome to fix it. >=20 No, that won't happen. Compat (single '@') symbols are only resolvable at runtime, bit at link time, so ld won't see any sem_ symbols in libthr and by necessity will pick ones from libc. --=20 Alexander Kabaev --Sig_/r1jJl/6LmJiltlx8/HPQCSW Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.13 (FreeBSD) iD8DBQFLQtOmQ6z1jMm+XZYRAtNPAKCcgaPECN3d4E0hz0if5Vh1/RX6ggCfbL+f 3KL2Sr7OKHUWX5F2SMc0IoY= =P1Cy -----END PGP SIGNATURE----- --Sig_/r1jJl/6LmJiltlx8/HPQCSW--