From owner-freebsd-net@FreeBSD.ORG  Fri Apr 25 22:42:59 2014
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id D5A4312F
 for <freebsd-net@freebsd.org>; Fri, 25 Apr 2014 22:42:59 +0000 (UTC)
Received: from mail-wg0-x232.google.com (mail-wg0-x232.google.com
 [IPv6:2a00:1450:400c:c00::232])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 72CE6123C
 for <freebsd-net@freebsd.org>; Fri, 25 Apr 2014 22:42:59 +0000 (UTC)
Received: by mail-wg0-f50.google.com with SMTP id x13so4148852wgg.33
 for <freebsd-net@freebsd.org>; Fri, 25 Apr 2014 15:42:56 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:date:message-id:subject:from:to:content-type;
 bh=IkdiDouvXzqw7FXT1pHQqVFrsbNkH/LbnuN4koU0gT8=;
 b=LgngB9JmhW8vWvOKXcCzgAoKn1zxEaFhT8ZNvxG2EegOrSU19tlgCdsms57co02WRd
 6FeOjIGYPABrIc45z6oNRe9/DHrMNf4LAUPgzgtt2OrP1IT5SqWURhJY8z/p512coai7
 RB+R/2jKXKUG19MAbSqyQKcCG4t1tpfDj1ErF9rYh/hHllBM8/DwAjRMXBXLOGqJFacU
 QjkCa2ulC6+3BGdtHfjnhFBssI2r5xWwsHxATr+EDZWdLoHXGZdn3SrN5tjfmiVTpi44
 HVcK6JOGDpc0vLBEYsohT8TOapUztV+0Wf9J8J1nWvOZ2SrytDtoL5z9CMuV+BqOJRSE
 lPmQ==
MIME-Version: 1.0
X-Received: by 10.180.218.35 with SMTP id pd3mr5555544wic.26.1398465776868;
 Fri, 25 Apr 2014 15:42:56 -0700 (PDT)
Sender: asomers@gmail.com
Received: by 10.194.168.130 with HTTP; Fri, 25 Apr 2014 15:42:56 -0700 (PDT)
Date: Fri, 25 Apr 2014 16:42:56 -0600
X-Google-Sender-Auth: Cm4eDnkRg_IVqmgECZW7iRtiK7g
Message-ID: <CAOtMX2jXHwJJ9CBz9kVVUYVX7d_uKxkLqieuWFbxDNTbBNfWVw@mail.gmail.com>
Subject: Please review: fix page fault panic in lacp_req
From: Alan Somers <asomers@freebsd.org>
To: FreeBSD Net <freebsd-net@freebsd.org>
Content-Type: text/plain; charset=UTF-8
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 25 Apr 2014 22:42:59 -0000

If you do an "ifconfig -am" in one thread while doing an "ifconfig
lagg0 destroy" in another thread, at least two panics may result. One
is in lacp_req(), caused by NULL == lsc.  I opened kern/189003 to
describe it.  I'm still working on the other panic or panics.

Full explanation and patch are at
http://www.freebsd.org/cgi/query-pr.cgi?pr=189003&cat= .  Can somebody
please review the patch?

-Alan