From owner-freebsd-hackers@freebsd.org Tue Jul 21 05:33:10 2020 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id ABD0E3785CD for ; Tue, 21 Jul 2020 05:33:10 +0000 (UTC) (envelope-from sega01@go-beyond.org) Received: from balrog.mythic-beasts.com (balrog.mythic-beasts.com [IPv6:2a00:1098:0:82:1000:0:2:1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4B9nLY6015z497T for ; Tue, 21 Jul 2020 05:33:09 +0000 (UTC) (envelope-from sega01@go-beyond.org) Received: from [160.3.200.8] (port=55732 helo=localhost) by balrog.mythic-beasts.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92.3) (envelope-from ) id 1jxktj-0003kE-HK for freebsd-hackers@freebsd.org; Tue, 21 Jul 2020 06:33:08 +0100 Date: Tue, 21 Jul 2020 05:32:59 +0000 From: Teran McKinney To: freebsd-hackers@freebsd.org Subject: SA:20-19 Unbound patch is broken for 12.1 Message-ID: <20200721053259.GA21070@daemon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-BlackCat-Spam-Score: 4 X-Spam-Status: No, score=0.4 X-Rspamd-Queue-Id: 4B9nLY6015z497T X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of sega01@go-beyond.org designates 2a00:1098:0:82:1000:0:2:1 as permitted sender) smtp.mailfrom=sega01@go-beyond.org X-Spamd-Result: default: False [-1.44 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.69)[-0.694]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1098::82:1000:0:2:1]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; DMARC_NA(0.00)[go-beyond.org]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-0.86)[-0.865]; MID_RHS_NOT_FQDN(0.50)[]; NEURAL_SPAM_SHORT(0.02)[0.020]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:44684, ipnet:2a00:1098::/32, country:GB]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; RCVD_IN_DNSWL_LOW(-0.10)[2a00:1098:0:82:1000:0:2:1:from] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jul 2020 05:33:10 -0000 Hi everyone, It looks like the SA:20-19 Unbound patch for 12.1 is broken. Patch applies cleanly, but it breaks `make buildworld`. Given that it's a security advisory, I figured it wouldn't hurt to get more eyes on it. I'm running into this on my laptop and a fresh install. ---- bash# pwd /usr/src/usr.sbin/unbound bash# make ===> daemon (all) cc -O2 -pipe -I/usr/src/contrib/unbound -I/usr/src/contrib/ldns -I/usr/src/usr.sbin/unbound -I/usr/src/usr.sbin/unbound/daemon -g -MD -MF.depend.acl_list.o -MTacl_list.o -std=gnu99 -fstack-protector-strong -Wsystem-headers -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -Wmissing-variable-declarations -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable -Qunused-arguments -c /usr/src/contrib/unbound/daemon/acl_list.c -o acl_list.o In file included from /usr/src/contrib/unbound/daemon/acl_list.c:43: In file included from /usr/src/contrib/unbound/daemon/acl_list.h:45: In file included from /usr/src/contrib/unbound/util/storage/dnstree.h:45: /usr/src/contrib/unbound/util/rbtree.h:65:2: error: unknown type name 'uint8_t' uint8_t color; ^ /usr/src/contrib/unbound/util/rbtree.h:81:2: error: unknown type name 'size_t' size_t count; ^ In file included from /usr/src/contrib/unbound/daemon/acl_list.c:43: In file included from /usr/src/contrib/unbound/daemon/acl_list.h:45: /usr/src/contrib/unbound/util/storage/dnstree.h:61:2: error: unknown type name 'uint8_t' uint8_t* name; ^ /usr/src/contrib/unbound/util/storage/dnstree.h:63:2: error: unknown type name 'size_t' size_t len; ^ /usr/src/contrib/unbound/util/storage/dnstree.h:67:2: error: unknown type name 'uint16_t' uint16_t dclass; ^ /usr/src/contrib/unbound/util/storage/dnstree.h:83:26: error: field has incomplete type 'struct sockaddr_storage' struct sockaddr_storage addr; ^ /usr/src/contrib/unbound/util/storage/dnstree.h:83:9: note: forward declaration of 'struct sockaddr_storage' struct sockaddr_storage addr; ^ /usr/src/contrib/unbound/util/storage/dnstree.h:85:2: error: unknown type name 'socklen_t' socklen_t addrlen; ^ /usr/src/contrib/unbound/util/storage/dnstree.h:109:2: error: unknown type name 'uint8_t' uint8_t* name, size_t len, int labs, uint16_t dclass); ^ /usr/src/contrib/unbound/util/storage/dnstree.h:109:17: error: unknown type name 'size_t' uint8_t* name, size_t len, int labs, uint16_t dclass); ^ /usr/src/contrib/unbound/util/storage/dnstree.h:109:39: error: unknown type name 'uint16_t' uint8_t* name, size_t len, int labs, uint16_t dclass); ^ /usr/src/contrib/unbound/util/storage/dnstree.h:127:58: error: unknown type name 'uint8_t' struct name_tree_node* name_tree_find(rbtree_type* tree, uint8_t* name, ^ /usr/src/contrib/unbound/util/storage/dnstree.h:128:2: error: unknown type name 'size_t' size_t len, int labs, uint16_t dclass); ^ /usr/src/contrib/unbound/util/storage/dnstree.h:128:24: error: unknown type name 'uint16_t' size_t len, int labs, uint16_t dclass); ^ /usr/src/contrib/unbound/util/storage/dnstree.h:139:60: error: unknown type name 'uint8_t' struct name_tree_node* name_tree_lookup(rbtree_type* tree, uint8_t* name, ^ /usr/src/contrib/unbound/util/storage/dnstree.h:140:2: error: unknown type name 'size_t' size_t len, int labs, uint16_t dclass); ^ /usr/src/contrib/unbound/util/storage/dnstree.h:140:24: error: unknown type name 'uint16_t' size_t len, int labs, uint16_t dclass); ^ /usr/src/contrib/unbound/util/storage/dnstree.h:148:44: error: unknown type name 'uint16_t' int name_tree_next_root(rbtree_type* tree, uint16_t* dclass); ^ /usr/src/contrib/unbound/util/storage/dnstree.h:167:33: error: unknown type name 'socklen_t' struct sockaddr_storage* addr, socklen_t addrlen, int net); ^ /usr/src/contrib/unbound/util/storage/dnstree.h:191:33: error: unknown type name 'socklen_t' struct sockaddr_storage* addr, socklen_t addrlen); ^ fatal error: too many errors emitted, stopping now [-ferror-limit=] 20 errors generated. *** Error code 1 Stop. make[1]: stopped in /usr/src/usr.sbin/unbound/daemon *** Error code 1 Stop. make: stopped in /usr/src/usr.sbin/unbound ---- Someone already opened a bug for it, but I think it's under the wrong component and may not be getting to the right people. Bug #248010. -Teran