From owner-freebsd-hackers Wed Apr 12 11:41:11 1995 Return-Path: hackers-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id LAA19894 for hackers-outgoing; Wed, 12 Apr 1995 11:41:11 -0700 Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.34]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id LAA19886 for ; Wed, 12 Apr 1995 11:40:58 -0700 Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.9/8.6.9) id EAA23231; Thu, 13 Apr 1995 04:30:24 +1000 Date: Thu, 13 Apr 1995 04:30:24 +1000 From: Bruce Evans Message-Id: <199504121830.EAA23231@godzilla.zeta.org.au> To: babkin@hq.icb.chel.su, davidg@Root.COM Subject: Re: SLIP bug ? Cc: freebsd-hackers@FreeBSD.org Sender: hackers-owner@FreeBSD.org Precedence: bulk >I have found a little bug in SLIP (950210-SNAP). Comment says that SLIP >must mask both network and tty interrupts by spl...(), but really >it masks splimp() only. Is this error corrected in -current ? If not This has never been a problem in FreeBSD or 386BSD. splimp() masks ttys too if SLIP or PPP is (statically) configured. See isa.c. There used to be variations on the problem. A long time ago, splnet() was null unless there was a network interface (ethernet or SLIP), but it has to be no-null for lo0, was a network interface (ethernet or slip), but it has to be no-null for lo0. More recently, isa.c forgot to handle the (NPPP > 0) case. Bruce