From owner-freebsd-bugs@FreeBSD.ORG Tue Nov 11 04:30:24 2003 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CE19D16A4CE for ; Tue, 11 Nov 2003 04:30:24 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 83E2943FDD for ; Tue, 11 Nov 2003 04:30:23 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id hABCUNFY020708 for ; Tue, 11 Nov 2003 04:30:23 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.9/8.12.9/Submit) id hABCUN95020707; Tue, 11 Nov 2003 04:30:23 -0800 (PST) (envelope-from gnats) Date: Tue, 11 Nov 2003 04:30:23 -0800 (PST) Message-Id: <200311111230.hABCUN95020707@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Georg Graf Subject: Re: kern/49980: patch to enable ThinkPAD X24 sound device (Intel 82801CA (ICH3)) X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Georg Graf List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Nov 2003 12:30:24 -0000 The following reply was made to PR kern/49980; it has been noted by GNATS. From: Georg Graf To: freebsd-gnats-submit@FreeBSD.org, kawasaki@kawasaki3.org, georg@graf.priv.at Cc: Subject: Re: kern/49980: patch to enable ThinkPAD X24 sound device (Intel 82801CA (ICH3)) Date: Tue, 11 Nov 2003 13:22:42 +0100 The patch does not apply, because the source files changed. I suggest the following: -) The patch against pci.c should not be applied, instead somewhere the info should be put, that "options PCI_ENABLE_IO_MODES" belongs into the kernel config. -) The patch for sys/pci/pcisupport.c effectively enables the sound of this kute thinkpad. IMO it just needs to be committed into the right file in sys/dev/. It works perfectly for me for FreeBSD 4.8 RELEASE. Please commit, and lots of thanks, George