From owner-freebsd-sparc64@FreeBSD.ORG Thu Apr 7 12:51:25 2005 Return-Path: Delivered-To: freebsd-sparc64@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3815216A4CE; Thu, 7 Apr 2005 12:51:25 +0000 (GMT) Received: from gw.celabo.org (gw.celabo.org [208.42.49.153]) by mx1.FreeBSD.org (Postfix) with ESMTP id C772943D3F; Thu, 7 Apr 2005 12:51:24 +0000 (GMT) (envelope-from nectar@FreeBSD.org) Received: from gw.celabo.org (localhost [127.0.0.1]) by internal.gw.celabo.org (Postfix) with ESMTP id 8C2DC3E2E70; Thu, 7 Apr 2005 07:51:17 -0500 (CDT) Received: from lum.celabo.org (lum.celabo.org [10.0.1.107]) by gw.celabo.org (Postfix) with ESMTP id 848D83E2E6F; Thu, 7 Apr 2005 07:51:17 -0500 (CDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) by lum.celabo.org (Postfix) with ESMTP id 79128659EA; Thu, 7 Apr 2005 07:51:15 -0500 (CDT) In-Reply-To: <20050406153614.BA6877306E@freebsd-current.sentex.ca> References: <20050406153614.BA6877306E@freebsd-current.sentex.ca> Mime-Version: 1.0 (Apple Message framework v619.2) Content-Type: multipart/mixed; boundary=Apple-Mail-6--720396101 Message-Id: From: Jacques Vidrine Date: Thu, 7 Apr 2005 07:51:13 -0500 To: X-Mailer: Apple Mail (2.619.2) X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on hellblazer.celabo.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.0.2 cc: sparc64@freebsd.org Subject: Re: [current tinderbox] failure on sparc64/sparc64 X-BeenThere: freebsd-sparc64@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting FreeBSD to the Sparc List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Apr 2005 12:51:25 -0000 --Apple-Mail-6--720396101 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed On Apr 6, 2005, at 10:36 AM, FreeBSD Tinderbox wrote: > /tinderbox/CURRENT/sparc64/sparc64/src/libexec/rexecd/rexecd.c: In > function `doit': > /tinderbox/CURRENT/sparc64/sparc64/src/libexec/rexecd/rexecd.c:204: > warning: cast increases required alignment of target type > *** Error code 1 Gah, I'm cursed. 139 char user[16], pass[16]; 204 !pam_ok(pam_get_item(pamh, PAM_USER, (const void **)&user)) || Before I churn the code more :-/, does someone have a much better suggestion than the attached? Cheers, -- Jacques A Vidrine / NTT/Verio nectar@celabo.org / jvidrine@verio.net / nectar@freebsd.org --Apple-Mail-6--720396101 Content-Transfer-Encoding: 7bit Content-Type: application/octet-stream; x-unix-mode=0644; name="rexecd.patch" Content-Disposition: attachment; filename=rexecd.patch ? rexecd ? rexecd.8.gz Index: rexecd.c =================================================================== RCS file: /home/ncvs/src/libexec/rexecd/rexecd.c,v retrieving revision 1.39 diff -c -u -r1.39 rexecd.c --- rexecd.c 5 Apr 2005 18:25:27 -0000 1.39 +++ rexecd.c 7 Apr 2005 12:45:55 -0000 @@ -136,9 +136,9 @@ { char *cmdbuf, *cp; int maxcmdlen; - char user[16], pass[16]; + char userbuf[16], pass[16]; struct passwd *pwd, pwd_storage; - char *pwdbuf; + char *pwdbuf, *user; size_t pwdbuflen; int fd, r, sd; u_short port; @@ -189,6 +189,7 @@ if (connect(sd, fromp, fromp->sa_len) < 0) exit(1); } + user = userbuf; getstr(user, sizeof(user), "username"); getstr(pass, sizeof(pass), "password"); getstr(cmdbuf, maxcmdlen, "command"); --Apple-Mail-6--720396101 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed --Apple-Mail-6--720396101--