From owner-freebsd-current@FreeBSD.ORG Wed Nov 26 12:31:39 2008 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B19A2106564A for ; Wed, 26 Nov 2008 12:31:39 +0000 (UTC) (envelope-from insomniac@slackware.it) Received: from aa002msb.fastweb.it (aa002msb.fastweb.it [85.18.95.81]) by mx1.freebsd.org (Postfix) with ESMTP id 3FFCC8FC14 for ; Wed, 26 Nov 2008 12:31:39 +0000 (UTC) (envelope-from insomniac@slackware.it) Received: from beastie (39.255.187.177) by aa002msb.fastweb.it (8.0.013.8) id 49222A7801537843 for freebsd-current@freebsd.org; Wed, 26 Nov 2008 13:20:26 +0100 Date: Wed, 26 Nov 2008 13:20:25 +0100 From: insomniac To: freebsd-current@freebsd.org Message-ID: <20081126132025.07e968b7@beastie> In-Reply-To: <492CC391.2070207@delphij.net> References: <20081126032214.03d8517a@slackware.it> <492CC391.2070207@delphij.net> Organization: Slackware Linux Project Italia (SLP-IT) X-Mailer: Claws Mail 3.3.0 (GTK+ 2.12.1; i386-portbld-freebsd7.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: Patch for bin/54446 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Nov 2008 12:31:39 -0000 On Tue, 25 Nov 2008 19:33:37 -0800 Xin LI wrote: > I have made a small change: use malloc() here and use strlcpy(). > Other parts looks just fine. > > (BTW I think we need to cc portmgr@ for approval) I merged your fix with Garrett Cooper's one (I forgot to free() before a return) and also mailed portmgr@ for approval. The new patch is located at the same link: http://insomniac.slackware.it/plist.c.diff Moreover, I will fix style(9) in a second step. Best regards, -- Andrea Barberio a.barberio@oltrelinux.com - Linux&C. andrea.barberio@slackware.it - Slackware Linux Project Italia GPG key on http://insomniac.slackware.it/gpgkey.asc 2818 A961 D6D8 1A8C 6E84 6181 5FA6 03B2 E68A 0B7D SIP: 5327786, Phone: 06 916503784